Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
336993003:
Fix untrusted.gypi to generate correct list of dependecies (Closed)
|
Created:
6 years, 6 months ago by Sergey Ulanov Modified:
6 years, 6 months ago Reviewers:
noelallen1 CC:
native-client-reviews_googlegroups.com Visibility:
Public. |
DescriptionFix untrusted.gypi to generate correct list of dependecies
Untrusted.gypi uses scan_sources.py to get list of depdendencies for
given list of sources. Previously it didn't specify correct list of
include directories, and as result wasn't generating correct list of
dependencies.
BUG=384752
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Messages
Total messages: 14 (0 generated)
ping
lgtm although I wish there was a cleaner way than removing OptionParser.
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/sergeyu@chromium.org/336993003/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: nacl-arm_opt_panda on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_opt_panda/builds...) nacl-mac10.6-newlib-dbg-clang on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.6-newlib-dbg-c...) nacl-mac10.6_64_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.6_64_glibc_opt...) nacl-mac10.6_64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.6_64_newlib_db...) nacl-mac10.6_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.6_glibc_opt/bu...) nacl-mac10.6_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.6_newlib_opt/b...) nacl-mac10.7_64_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_64_glibc_opt...) nacl-mac10.7_64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_64_newlib_db...) nacl-mac10.7_arm_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_arm_newlib_o...) nacl-mac10.7_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_glibc_opt/bu...) nacl-mac10.7_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_newlib_opt/b...) nacl-mac10.8_32_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.8_32_glibc_opt...) nacl-mac10.8_32_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.8_32_newlib_db...) nacl-mac10.8_64_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.8_64_glibc_opt...) nacl-mac10.8_64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.8_64_newlib_db...) nacl-mac10.8_newlib_opt_pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.8_newlib_opt_p...) nacl-precise32_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_glibc_opt/...) nacl-precise32_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_newlib_dbg...) nacl-precise32_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_newlib_opt...) nacl-precise64-newlib-dbg-android on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64-newlib-dbg...) nacl-precise64-newlib-opt-android on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64-newlib-opt...) nacl-precise64_arm_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_arm_newlib...) nacl-precise64_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_glibc_opt/...) nacl-precise64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_newlib_dbg...) nacl-precise64_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_newlib_opt...) nacl-precise64_validator_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_validator_...) nacl-precise_64-newlib-arm_qemu-pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-ar...) nacl-precise_64-newlib-dbg-clang on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-db...) nacl-precise_64-newlib-mips-pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-mi...) nacl-precise_64-newlib-x86_32-pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...) nacl-precise_64-newlib-x86_32-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...) nacl-precise_64-newlib-x86_64-pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...) nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...) nacl-win32_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win32_glibc_opt/buil...) nacl-win32_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win32_newlib_opt/bui...) nacl-win64_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win64_glibc_opt/buil...) nacl-win64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win64_newlib_dbg/bui...) nacl-win64_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win64_newlib_opt/bui...) nacl-win7_64_arm_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win7_64_arm_newlib_o...) nacl-win7_64_newlib_opt_pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win7_64_newlib_opt_p...) nacl-win8-64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win8-64_newlib_dbg/b...) nacl-win8-64_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win8-64_newlib_opt/b...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: nacl-precise32_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_glibc_opt/...) nacl-precise32_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_newlib_dbg...) nacl-precise32_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_newlib_opt...)
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/sergeyu@chromium.org/336993003/80001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: nacl-arm_opt_panda on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-arm_opt_panda/builds...) nacl-mac10.6-newlib-dbg-clang on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.6-newlib-dbg-c...) nacl-mac10.6_64_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.6_64_glibc_opt...) nacl-mac10.6_64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.6_64_newlib_db...) nacl-mac10.6_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.6_glibc_opt/bu...) nacl-mac10.6_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.6_newlib_opt/b...) nacl-mac10.7_64_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_64_glibc_opt...) nacl-mac10.7_64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_64_newlib_db...) nacl-mac10.7_arm_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_arm_newlib_o...) nacl-mac10.7_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_glibc_opt/bu...) nacl-mac10.7_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_newlib_opt/b...) nacl-mac10.8_32_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.8_32_glibc_opt...) nacl-mac10.8_32_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.8_32_newlib_db...) nacl-mac10.8_64_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.8_64_glibc_opt...) nacl-mac10.8_64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.8_64_newlib_db...) nacl-mac10.8_newlib_opt_pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.8_newlib_opt_p...) nacl-precise32_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_glibc_opt/...) nacl-precise32_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_newlib_dbg...) nacl-precise32_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_newlib_opt...) nacl-precise64-newlib-dbg-android on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64-newlib-dbg...) nacl-precise64-newlib-opt-android on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64-newlib-opt...) nacl-precise64_arm_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_arm_newlib...) nacl-precise64_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_glibc_opt/...) nacl-precise64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_newlib_dbg...) nacl-precise64_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_newlib_opt...) nacl-precise64_validator_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise64_validator_...) nacl-precise_64-newlib-arm_qemu-pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-ar...) nacl-precise_64-newlib-dbg-clang on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-db...) nacl-precise_64-newlib-mips-pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-mi...) nacl-precise_64-newlib-x86_32-pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...) nacl-precise_64-newlib-x86_32-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...) nacl-precise_64-newlib-x86_64-pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...) nacl-precise_64-newlib-x86_64-pnacl-spec on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise_64-newlib-x8...) nacl-win32_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win32_glibc_opt/buil...) nacl-win32_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win32_newlib_opt/bui...) nacl-win64_glibc_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win64_glibc_opt/buil...) nacl-win64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win64_newlib_dbg/bui...) nacl-win64_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win64_newlib_opt/bui...) nacl-win7_64_arm_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win7_64_arm_newlib_o...) nacl-win7_64_newlib_opt_pnacl on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win7_64_newlib_opt_p...) nacl-win8-64_newlib_dbg on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win8-64_newlib_dbg/b...) nacl-win8-64_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-win8-64_newlib_opt/b...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: nacl-precise32_newlib_opt on tryserver.nacl (http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_newlib_opt...)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
