Issue 350703004: Fix untrusted.gypi to generate correct list of dependecies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 350703004: Fix untrusted.gypi to generate correct list of dependecies (Closed)

Created:
6 years, 6 months ago by noelallen1

Modified:
6 years, 6 months ago

Reviewers:
bradnelson, bradn

CC:
native-client-reviews_googlegroups.com, Sergey Ulanov

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

Fix untrusted.gypi to generate correct list of dependecies Untrusted.gypi uses scan_sources.py to get list of depdendencies for given list of sources. Previously it didn't specify correct list of include directories, and as result wasn't generating correct list of dependencies. BUG=384752 R=bradnelson@google.com TBR=bradnelson@google.com Brad, could you rubber stamp, I already reviewed this on behalf of sergeyu@chromium.org see: https://codereview.chromium.org/336993003/ Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13393

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -70 lines)			Patch
	M	build/scan_sources.py	View		2 chunks	+17 lines, -13 lines	0 comments	Download
	M	build/untrusted.gypi	View		33 chunks	+30 lines, -57 lines	0 comments	Download

Total messages: 3 (0 generated)

noelallen1

6 years, 6 months ago (2014-06-23 21:41:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13393 (presubmit successful).