Issue 336983002: Fix NULL deref in safe browsing preference validation delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336983002: Fix NULL deref in safe browsing preference validation delegate. (Closed)

Created:
6 years, 6 months ago by grt (UTC plus 2)

Modified:
6 years, 6 months ago

Reviewers:
gab, mattm

CC:
chromium-reviews, amineer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix NULL deref in safe browsing preference validation delegate. BUG=384729 TBR=mattm@chromium.org,gab@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277282

Patch Set 1 #

Patch Set 2 : parens #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h	View		2 chunks	+6 lines, -5 lines	0 comments	Download
	M	chrome/browser/safe_browsing/preference_validation_delegate.cc	View	1	2 chunks	+5 lines, -4 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

grt (UTC plus 2)

This fix to a canary crasher is very straightforward, so I'll land it directly once ...

6 years, 6 months ago (2014-06-14 22:06:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/336983002/20001

6 years, 6 months ago (2014-06-15 00:00:54 UTC) #3

gab

6 years, 6 months ago (2014-06-16 15:45:03 UTC) #5

Message was sent while issue was closed.

lgtm w/ extra request

https://codereview.chromium.org/336983002/diff/20001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/preference_validation_delegate.cc (right):

https://codereview.chromium.org/336983002/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/preference_validation_delegate.cc:75: const
base::DictionaryValue* dict_value,
This parameter is also unused, comment it out.

Expand Messages | Collapse Messages