Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h

Issue 336983002: Fix NULL deref in safe browsing preference validation delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: parens Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h
diff --git a/chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h b/chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h
index d421bb5a8455580a0e4caa21bc3e791cd00e27e7..a2e91acfe3ba975754e0d15a0c5342278adc89dd 100644
--- a/chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h
+++ b/chrome/browser/prefs/tracked/tracked_preference_validation_delegate.h
@@ -23,8 +23,9 @@ class TrackedPreferenceValidationDelegate {
virtual ~TrackedPreferenceValidationDelegate() {}
// Notifies observes of the result (|value_state|) of checking the atomic
- // |value| at |pref_path|. |reset_action| indicates whether or not a reset
- // will occur based on |value_state| and the enforcement level in place.
+ // |value| (which may be NULL) at |pref_path|. |reset_action| indicates
+ // whether or not a reset will occur based on |value_state| and the
+ // enforcement level in place.
virtual void OnAtomicPreferenceValidation(
const std::string& pref_path,
const base::Value* value,
@@ -32,9 +33,9 @@ class TrackedPreferenceValidationDelegate {
TrackedPreferenceHelper::ResetAction reset_action) = 0;
// Notifies observes of the result (|value_state|) of checking the split
- // |dict_value| at |pref_path|. |reset_action| indicates whether or not a
- // reset of |value_keys| will occur based on |value_state| and the enforcement
- // level in place.
+ // |dict_value| (which may be NULL) at |pref_path|. |reset_action| indicates
+ // whether or not a reset of |value_keys| will occur based on |value_state|
+ // and the enforcement level in place.
virtual void OnSplitPreferenceValidation(
const std::string& pref_path,
const base::DictionaryValue* dict_value,

Powered by Google App Engine
This is Rietveld 408576698