Adds API test for imageWriterPrivate.writeFromFile

Adds API test for imageWriterPrivate.writeFromFile

BUG=384650
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282130

[Drew Haven, 2014-06-16 19:20:22]

Antony,

Here's the next installment of my API tests.  This time testing the
write-image-from-file flow.

I did some refactoring to put some common elements in a class called
ImageWriterTestUtils so that I could include it easily in both unit tests and
API tests.

Would you mind taking a look when you have time?

-- Drew

[asargent_no_longer_on_chrome, 2014-06-17 15:47:32]

lgtm

https://codereview.chromium.org/336923002/diff/60001/chrome/test/data/extensi...
File
chrome/test/data/extensions/api_test/image_writer_private/write_from_file/test.js
(right):

https://codereview.chromium.org/336923002/diff/60001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/image_writer_private/write_from_file/test.js:36:
chrome.test.assertTrue(!!storageDevice.storageUnitId,
nit: I think it's a little more common in the extensions code to test for
undefined/null by doing:

if (typeof(foo) != "undefined") {
  ...
}

The problem with using !! is that it can, for instance, give results you might
not expect for an integer value of 0 and a string value of "".

[Drew Haven, 2014-06-17 20:25:07]

https://codereview.chromium.org/336923002/diff/60001/chrome/test/data/extensi...
File
chrome/test/data/extensions/api_test/image_writer_private/write_from_file/test.js
(right):

https://codereview.chromium.org/336923002/diff/60001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/image_writer_private/write_from_file/test.js:36:
chrome.test.assertTrue(!!storageDevice.storageUnitId,
On 2014/06/17 15:47:32, Antony Sargent wrote:
> nit: I think it's a little more common in the extensions code to test for
> undefined/null by doing:
> 
> if (typeof(foo) != "undefined") {
>   ...
> }
> 
> The problem with using !! is that it can, for instance, give results you might
> not expect for an integer value of 0 and a string value of "". 
> 

Good idea.  For the case of null and undefined I believe I can just get away
with using === instead of a string comparison on type.  I'll give it a test.

[Drew Haven, 2014-06-17 20:55:33]

The CQ bit was checked by haven@chromium.org

[commit-bot: I haz the power, 2014-06-17 20:57:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haven@chromium.org/336923002/80001

[Drew Haven, 2014-06-19 01:41:27]

The CQ bit was checked by haven@chromium.org

[commit-bot: I haz the power, 2014-06-19 01:42:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haven@chromium.org/336923002/140001

[commit-bot: I haz the power, 2014-06-19 10:03:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 10:03:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Drew Haven, 2014-07-09 18:20:13]

The CQ bit was checked by haven@chromium.org

[commit-bot: I haz the power, 2014-07-09 18:22:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haven@chromium.org/336923002/200001

[commit-bot: I haz the power, 2014-07-09 21:33:07]

Change committed as 282130

[dgrogan, 2014-07-09 22:18:42]

Reverted in r282141.

Leak detected by Linux ASan LSan Tests (2).
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...