Adds API test for imageWriterPrivate.writeFromFile

chrome/browser/extensions/api/image_writer_private/operation_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "chrome/browser/extensions/api/image_writer_private/error_messages.h"
 #include "chrome/browser/extensions/api/image_writer_private/operation.h"
@@ skipping 53 matching lines @@
 };
 
 class ImageWriterOperationTest : public ImageWriterUnitTestBase {
  protected:
   ImageWriterOperationTest()
       : profile_(new TestingProfile), manager_(profile_.get()) {}
   virtual void SetUp() OVERRIDE {
     ImageWriterUnitTestBase::SetUp();
 
     // Create the zip file.
-    base::FilePath image_dir = temp_dir_.path().AppendASCII("zip");
+    base::FilePath image_dir = test_utils_.GetTempDir().AppendASCII("zip");
     ASSERT_TRUE(base::CreateDirectory(image_dir));
     ASSERT_TRUE(base::CreateTemporaryFileInDir(image_dir, &image_path_));
 
-    FillFile(image_path_, kImagePattern, kTestFileSize);
+    test_utils_.FillFile(image_path_, kImagePattern, kTestFileSize);
 
-    zip_file_ = temp_dir_.path().AppendASCII("test_image.zip");
+    zip_file_ = test_utils_.GetTempDir().AppendASCII("test_image.zip");
     ASSERT_TRUE(zip::Zip(image_dir, zip_file_, true));
 
     // Operation setup.
-    operation_ = new OperationForTest(manager_.AsWeakPtr(),
-                                      kDummyExtensionId,
-                                      test_device_path_.AsUTF8Unsafe());
-    client_ = FakeImageWriterClient::Create();
-    operation_->SetImagePath(test_image_path_);
+    operation_ =
+        new OperationForTest(manager_.AsWeakPtr(),
+                             kDummyExtensionId,
+                             test_utils_.GetDevicePath().AsUTF8Unsafe());
+    operation_->SetImagePath(test_utils_.GetImagePath());
   }
 
   virtual void TearDown() OVERRIDE {
     // Ensure all callbacks have been destroyed and cleanup occurs.
-    client_->Shutdown();
     operation_->Cancel();
 
     ImageWriterUnitTestBase::TearDown();
   }
 
   base::FilePath image_path_;
   base::FilePath zip_file_;
 
   scoped_ptr<TestingProfile> profile_;
 
   MockOperationManager manager_;
-  scoped_refptr<FakeImageWriterClient> client_;
   scoped_refptr<OperationForTest> operation_;
 };
 
 } // namespace
 
 // Unizpping a non-zip should do nothing.
 TEST_F(ImageWriterOperationTest, UnzipNonZipFile) {
   EXPECT_CALL(manager_, OnProgress(kDummyExtensionId, _, _)).Times(0);
 
   EXPECT_CALL(manager_, OnError(kDummyExtensionId, _, _, _)).Times(0);
@@ skipping 31 matching lines @@
       base::Bind(
           &OperationForTest::Unzip, operation_, base::Bind(&base::DoNothing)));
 
   base::RunLoop().RunUntilIdle();
 
   EXPECT_TRUE(base::ContentsEqual(image_path_, operation_->GetImagePath()));
 }
 
 #if defined(OS_LINUX)
 TEST_F(ImageWriterOperationTest, WriteImageToDevice) {
-#if !defined(OS_CHROMEOS)
-  operation_->SetUtilityClientForTesting(client_);
-#endif
-
   EXPECT_CALL(manager_, OnError(kDummyExtensionId, _, _, _)).Times(0);
   EXPECT_CALL(manager_,
               OnProgress(kDummyExtensionId, image_writer_api::STAGE_WRITE, _))
       .Times(AtLeast(1));
   EXPECT_CALL(manager_,
               OnProgress(kDummyExtensionId, image_writer_api::STAGE_WRITE, 0))
       .Times(AtLeast(1));
   EXPECT_CALL(manager_,
               OnProgress(kDummyExtensionId, image_writer_api::STAGE_WRITE, 100))
       .Times(AtLeast(1));
 
   operation_->Start();
   content::BrowserThread::PostTask(
       content::BrowserThread::FILE,
       FROM_HERE,
       base::Bind(
           &OperationForTest::Write, operation_, base::Bind(&base::DoNothing)));
 
   base::RunLoop().RunUntilIdle();
 
 #if !defined(OS_CHROMEOS)
-  client_->Progress(0);
-  client_->Progress(kTestFileSize / 2);
-  client_->Progress(kTestFileSize);
-  client_->Success();
+  test_utils_.GetUtilityClient()->Progress(0);
+  test_utils_.GetUtilityClient()->Progress(kTestFileSize / 2);
+  test_utils_.GetUtilityClient()->Progress(kTestFileSize);
+  test_utils_.GetUtilityClient()->Success();
 
   base::RunLoop().RunUntilIdle();
 #endif
 }
 #endif
 
 #if !defined(OS_CHROMEOS)
 // Chrome OS doesn't support verification in the ImageBurner, so these two tests
 // are skipped.
 
 TEST_F(ImageWriterOperationTest, VerifyFileSuccess) {
-  operation_->SetUtilityClientForTesting(client_);
-
   EXPECT_CALL(manager_, OnError(kDummyExtensionId, _, _, _)).Times(0);
   EXPECT_CALL(
       manager_,
       OnProgress(kDummyExtensionId, image_writer_api::STAGE_VERIFYWRITE, _))
       .Times(AtLeast(1));
   EXPECT_CALL(
       manager_,
       OnProgress(kDummyExtensionId, image_writer_api::STAGE_VERIFYWRITE, 0))
       .Times(AtLeast(1));
   EXPECT_CALL(
       manager_,
       OnProgress(kDummyExtensionId, image_writer_api::STAGE_VERIFYWRITE, 100))
       .Times(AtLeast(1));
 
-  FillFile(test_device_path_, kImagePattern, kTestFileSize);
+  test_utils_.FillFile(
+      test_utils_.GetDevicePath(), kImagePattern, kTestFileSize);
 
   operation_->Start();
   content::BrowserThread::PostTask(content::BrowserThread::FILE,
                                    FROM_HERE,
                                    base::Bind(&OperationForTest::VerifyWrite,
                                               operation_,
                                               base::Bind(&base::DoNothing)));
 
   base::RunLoop().RunUntilIdle();
 
-  client_->Progress(0);
-  client_->Progress(kTestFileSize / 2);
-  client_->Progress(kTestFileSize);
-  client_->Success();
+#if !defined(OS_CHROMEOS)
+  test_utils_.GetUtilityClient()->Progress(0);
+  test_utils_.GetUtilityClient()->Progress(kTestFileSize / 2);
+  test_utils_.GetUtilityClient()->Progress(kTestFileSize);
+  test_utils_.GetUtilityClient()->Success();
+#endif
 
   base::RunLoop().RunUntilIdle();
 }
 
 TEST_F(ImageWriterOperationTest, VerifyFileFailure) {
-  operation_->SetUtilityClientForTesting(client_);
-
   EXPECT_CALL(
       manager_,
       OnProgress(kDummyExtensionId, image_writer_api::STAGE_VERIFYWRITE, _))
       .Times(AnyNumber());
   EXPECT_CALL(
       manager_,
       OnProgress(kDummyExtensionId, image_writer_api::STAGE_VERIFYWRITE, 100))
       .Times(0);
   EXPECT_CALL(manager_, OnComplete(kDummyExtensionId)).Times(0);
   EXPECT_CALL(
       manager_,
       OnError(kDummyExtensionId, image_writer_api::STAGE_VERIFYWRITE, _, _))
       .Times(1);
 
-  FillFile(test_device_path_, kDevicePattern, kTestFileSize);
+  test_utils_.FillFile(
+      test_utils_.GetDevicePath(), kDevicePattern, kTestFileSize);
 
   operation_->Start();
   content::BrowserThread::PostTask(content::BrowserThread::FILE,
                                    FROM_HERE,
                                    base::Bind(&OperationForTest::VerifyWrite,
                                               operation_,
                                               base::Bind(&base::DoNothing)));
 
   base::RunLoop().RunUntilIdle();
 
-  client_->Progress(0);
-  client_->Progress(kTestFileSize / 2);
-  client_->Error(error::kVerificationFailed);
+  test_utils_.GetUtilityClient()->Progress(0);
+  test_utils_.GetUtilityClient()->Progress(kTestFileSize / 2);
+  test_utils_.GetUtilityClient()->Error(error::kVerificationFailed);
 
   base::RunLoop().RunUntilIdle();
 }
 #endif
 
 // Tests that on creation the operation_ has the expected state.
 TEST_F(ImageWriterOperationTest, Creation) {
   EXPECT_EQ(0, operation_->GetProgress());
   EXPECT_EQ(image_writer_api::STAGE_UNKNOWN, operation_->GetStage());
 }
 
 }  // namespace image_writer
 }  // namespace extensions