Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336863009: When performing offscreen rendering on windows, attempt to use a pbuffer context. (Closed)

Created:
6 years, 5 months ago by bsalomon
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia.git@klein
Visibility:
Public.

Description

When performing offscreen rendering on windows, attempt to use a pbuffer context. A pbuffer context is less likely to have a blocking SwapBuffers (due to vsync). Committed: https://skia.googlesource.com/skia/+/9245b7ee764b61222ffba409a7d2d7e62fde01a6

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix sampleapp #

Total comments: 4

Patch Set 4 : Address initial comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -47 lines) Patch
M include/gpu/gl/SkGLContextHelper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/gl/SkNativeGLContext.h View 2 chunks +2 lines, -0 lines 0 comments Download
M include/utils/SkWGL.h View 1 4 chunks +48 lines, -5 lines 0 comments Download
M src/gpu/gl/win/SkNativeGLContext_win.cpp View 5 chunks +49 lines, -9 lines 0 comments Download
M src/utils/win/SkWGL_win.cpp View 1 2 3 9 chunks +129 lines, -31 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
bsalomon
The motivation here is to have an offscreen context that won't be vsync'ed by the ...
6 years, 5 months ago (2014-06-30 19:52:36 UTC) #1
robertphillips
Initial comments - I'm going to take another pass through it. https://codereview.chromium.org/336863009/diff/40001/src/utils/win/SkWGL_win.cpp File src/utils/win/SkWGL_win.cpp (right): ...
6 years, 5 months ago (2014-06-30 20:03:33 UTC) #2
bsalomon
https://codereview.chromium.org/336863009/diff/40001/src/utils/win/SkWGL_win.cpp File src/utils/win/SkWGL_win.cpp (right): https://codereview.chromium.org/336863009/diff/40001/src/utils/win/SkWGL_win.cpp#newcode235 src/utils/win/SkWGL_win.cpp:235: , fSwapInterval(NULL){ On 2014/06/30 20:03:33, robertphillips wrote: > NULL ...
6 years, 5 months ago (2014-06-30 20:09:12 UTC) #3
robertphillips
lgtm + a suggestion https://codereview.chromium.org/336863009/diff/60001/src/utils/win/SkWGL_win.cpp File src/utils/win/SkWGL_win.cpp (right): https://codereview.chromium.org/336863009/diff/60001/src/utils/win/SkWGL_win.cpp#newcode400 src/utils/win/SkWGL_win.cpp:400: get_pixel_formats_to_try(dc, extensions, true, msaaSampleCount, pixelFormatsToTry); ...
6 years, 5 months ago (2014-06-30 20:33:21 UTC) #4
bsalomon
https://codereview.chromium.org/336863009/diff/60001/src/utils/win/SkWGL_win.cpp File src/utils/win/SkWGL_win.cpp (right): https://codereview.chromium.org/336863009/diff/60001/src/utils/win/SkWGL_win.cpp#newcode400 src/utils/win/SkWGL_win.cpp:400: get_pixel_formats_to_try(dc, extensions, true, msaaSampleCount, pixelFormatsToTry); On 2014/06/30 20:33:21, robertphillips ...
6 years, 5 months ago (2014-07-01 13:56:24 UTC) #5
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-01 13:56:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/336863009/60001
6 years, 5 months ago (2014-07-01 13:56:57 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 14:20:14 UTC) #8
Message was sent while issue was closed. 
Change committed as 9245b7ee764b61222ffba409a7d2d7e62fde01a6

Powered by Google App Engine
This is Rietveld 408576698