Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 336793004: Revert 277111 "Roll ICU to icu52" (Closed)

Created:
6 years, 6 months ago by Sorin Jianu
Modified:
6 years, 6 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 277111 "Roll ICU to icu52" It breaks a bunch of bots with a compile time error ../out/Release/gen/tc_pnacl_newlib/lib/libicuuc_nacl.a: error: undefined reference to 'icudt52_dat' For example: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Builder/builds/7531 > Roll ICU to icu52 > > The ICU update does the following among other things: > - Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG > encoding spec. > - Add CP866 > - Add far better/more extensive support for plural, format, etc > - Numerous locale data update > - Khmer/Lao line/word-breaking support > - More compact Chinese/Japanese dictionary (now a part of the upstream > instead of our local patch) > - Better plural support that we plan to use right away. > > - Update icu/BUILD.gn : file list update, new defines, etc. > - Update tests > a. icu_string_conversions_unittests : drop iscii (nobody uses it) and > remove JIS X 212 code points from the round-trip test > b. l10n_util_unittests: Display names for zh-*. > c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change). > d. Update Expected results in file_manager_browsertest/test_util.js > (see http://crbug.com/383930) > - Update SpellcheckerWordIterator > a. Add U+0027 back to MidNumLet > b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based > word-breaking. > - l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino) > - Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full > has 'at' before time, which is not handled by Date.parse() > - update license.py because we don't have a separate Chinese/Japanese > dictionary any more. It's now a part of ICU > > BUG=132145, 277023, 136148, 360433, 364072 > TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*, > browser_tests (encoding related, Iden*verifyGet*), > unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*, > layout tests (encoding, date/calendar, line breaking, and others), > build 'base_i18n_nacl', GN build bots. > > Review URL: https://codereview.chromium.org/265613002 TBR=jshin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -202 lines) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/base/i18n/icu_string_conversions_unittest.cc View 3 chunks +16 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/translate/translate_manager_render_view_host_unittest.cc View 5 chunks +25 lines, -24 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/identity_internals_ui_browsertest.js View 2 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/chrome/renderer/spellchecker/spellcheck_worditerator.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/api_test/file_manager_browsertest/test_util.js View 1 chunk +18 lines, -18 lines 0 comments Download
M trunk/src/components/query_parser/snippet.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/components/query_parser/snippet_unittest.cc View 1 chunk +49 lines, -48 lines 0 comments Download
M trunk/src/tools/gn/secondary/third_party/icu/BUILD.gn View 15 chunks +50 lines, -83 lines 0 comments Download
M trunk/src/tools/licenses.py View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/ui/base/l10n/l10n_util.cc View 1 chunk +14 lines, -5 lines 0 comments Download
M trunk/src/ui/base/l10n/l10n_util_unittest.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sorin Jianu
6 years, 6 months ago (2014-06-13 23:02:04 UTC) #1
Sorin Jianu
6 years, 6 months ago (2014-06-13 23:02:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r277117 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698