Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: trunk/src/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

Issue 336793004: Revert 277111 "Roll ICU to icu52" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
===================================================================
--- trunk/src/chrome/browser/translate/translate_manager_render_view_host_unittest.cc (revision 277116)
+++ trunk/src/chrome/browser/translate/translate_manager_render_view_host_unittest.cc (working copy)
@@ -6,7 +6,6 @@
#include <set>
#include <vector>
-#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "base/prefs/pref_change_registrar.h"
#include "base/prefs/pref_service.h"
@@ -622,24 +621,22 @@
}
}
-// A list of languages to fake being returned by the translate server.
-// Use only langauges for which Chrome's copy of ICU has
-// display names in English locale. To save space, Chrome's copy of ICU
-// does not have the display name for a language unless it's in the
-// Accept-Language list.
-static const char* server_language_list[] =
- {"ach", "ak", "af", "en-CA", "zh", "yi", "fr-FR", "tl", "iw", "in", "xx"};
-static const char* alpha_language_list[] = {"ach", "yi"};
-
// Test the fetching of languages from the translate server
TEST_F(TranslateManagerRenderViewHostTest, FetchLanguagesFromTranslateServer) {
std::vector<std::string> server_languages;
- for (size_t i = 0; i < arraysize(server_language_list); ++i)
- server_languages.push_back(server_language_list[i]);
+ // A list of languages to fake being returned by the translate server.
+ server_languages.push_back("aa");
+ server_languages.push_back("ak");
+ server_languages.push_back("ab");
+ server_languages.push_back("en-CA");
+ server_languages.push_back("zh");
+ server_languages.push_back("yi");
+ server_languages.push_back("fr-FR");
+ server_languages.push_back("xx");
std::vector<std::string> alpha_languages;
- for (size_t i = 0; i < arraysize(alpha_language_list); ++i)
- alpha_languages.push_back(alpha_language_list[i]);
+ alpha_languages.push_back("aa");
+ alpha_languages.push_back("yi");
// First, get the default languages list. Note that calling
// GetSupportedLanguages() invokes RequestLanguageList() internally.
@@ -675,12 +672,11 @@
EXPECT_NE(current_supported_languages.end(),
std::find(current_supported_languages.begin(),
current_supported_languages.end(),
- lang)) << "lang=" << lang;
+ lang));
bool is_alpha =
std::find(alpha_languages.begin(), alpha_languages.end(), lang) !=
alpha_languages.end();
- EXPECT_EQ(TranslateDownloadManager::IsAlphaLanguage(lang),
- is_alpha) << "lang=" << lang;
+ EXPECT_EQ(TranslateDownloadManager::IsAlphaLanguage(lang), is_alpha);
}
}
@@ -689,12 +685,18 @@
TEST_F(TranslateManagerRenderViewHostTest,
FetchLanguagesFromTranslateServerWithoutAlpha) {
std::vector<std::string> server_languages;
- for (size_t i = 0; i < arraysize(server_language_list); ++i)
- server_languages.push_back(server_language_list[i]);
+ server_languages.push_back("aa");
+ server_languages.push_back("ak");
+ server_languages.push_back("ab");
+ server_languages.push_back("en-CA");
+ server_languages.push_back("zh");
+ server_languages.push_back("yi");
+ server_languages.push_back("fr-FR");
+ server_languages.push_back("xx");
std::vector<std::string> alpha_languages;
- for (size_t i = 0; i < arraysize(alpha_language_list); ++i)
- alpha_languages.push_back(alpha_language_list[i]);
+ alpha_languages.push_back("aa");
+ alpha_languages.push_back("yi");
// call GetSupportedLanguages to call RequestLanguageList internally.
std::vector<std::string> default_supported_languages;
@@ -716,9 +718,8 @@
EXPECT_NE(current_supported_languages.end(),
std::find(current_supported_languages.begin(),
current_supported_languages.end(),
- lang)) << "lang=" << lang;
- EXPECT_FALSE(TranslateDownloadManager::IsAlphaLanguage(lang)) <<
- "lang=" << lang;
+ lang));
+ EXPECT_FALSE(TranslateDownloadManager::IsAlphaLanguage(lang));
}
}

Powered by Google App Engine
This is Rietveld 408576698