Get iossim to compile with Xcode 6.

Get iossim to compile with Xcode 6.

Xcode 6 moved the location of the frameworks that iossim depends on and
added a few new dependecies so new header files need to be generated by
the gyp target.

Note that this CL gets iossim to compile but iossim will not launch the
Xcode 6 simulator.

BUG=381213
NOTRY=true
TBR=rohitrao@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278786

[justincohen, 2014-06-13 13:36:08]

https://codereview.chromium.org/336773002/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (left):

https://codereview.chromium.org/336773002/diff/1/testing/iossim/iossim.mm#old...
testing/iossim/iossim.mm:45: @protocol DTiPhoneSimulatorSessionDelegate
Should we fix this as well, and actually pull this in somehow instead of
manually adding it?

[lliabraa, 2014-06-13 14:03:44]

https://codereview.chromium.org/336773002/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (left):

https://codereview.chromium.org/336773002/diff/1/testing/iossim/iossim.mm#old...
testing/iossim/iossim.mm:45: @protocol DTiPhoneSimulatorSessionDelegate
On 2014/06/13 13:36:07, justincohen wrote:
> Should we fix this as well, and actually pull this in somehow instead of
> manually adding it?  

I'm not sure how. I've class-dumped every framework in Xcode and there's never a
definition of this protocol; only references to it.

[justincohen, 2014-06-13 14:08:39]

LGTM

https://codereview.chromium.org/336773002/diff/1/testing/iossim/iossim.gyp
File testing/iossim/iossim.gyp (right):

https://codereview.chromium.org/336773002/diff/1/testing/iossim/iossim.gyp#ne...
testing/iossim/iossim.gyp:23: 'XCODE_6',
Is this necessary?  Would it be more correct to look for __IPHONE_8_0 ?

[lliabraa, 2014-06-13 15:07:30]

https://codereview.chromium.org/336773002/diff/1/testing/iossim/iossim.gyp
File testing/iossim/iossim.gyp (right):

https://codereview.chromium.org/336773002/diff/1/testing/iossim/iossim.gyp#ne...
testing/iossim/iossim.gyp:23: 'XCODE_6',
On 2014/06/13 14:08:39, justincohen wrote:
> Is this necessary?  Would it be more correct to look for __IPHONE_8_0 ?
> 

iossim is compiled for host so it uses the mac SDK and __IPHONE_* isn't
available.

Using __MAC_10_10 would work, but gyp/ninja chooses to the 10.9 SDK even though
10.10 is available. I'm not sure how to get it to use the 10.10 SDK. Setting the
GYP variable mac_sdk doesn't work (I'm guessing it get overridden somewhere down
the line).

[lliabraa, 2014-06-13 16:00:58]

On 2014/06/13 15:07:30, lliabraa wrote:
> https://codereview.chromium.org/336773002/diff/1/testing/iossim/iossim.gyp
> File testing/iossim/iossim.gyp (right):
> 
>
https://codereview.chromium.org/336773002/diff/1/testing/iossim/iossim.gyp#ne...
> testing/iossim/iossim.gyp:23: 'XCODE_6',
> On 2014/06/13 14:08:39, justincohen wrote:
> > Is this necessary?  Would it be more correct to look for __IPHONE_8_0 ?
> > 
> 
> iossim is compiled for host so it uses the mac SDK and __IPHONE_* isn't
> available.
> 
> Using __MAC_10_10 would work, but gyp/ninja chooses to the 10.9 SDK even
though
> 10.10 is available. I'm not sure how to get it to use the 10.10 SDK. Setting
the
> GYP variable mac_sdk doesn't work (I'm guessing it get overridden somewhere
down
> the line).

I've uploaded a patch that uses the 10.10 SDK (and __MAC_10_10 instead of
XCODE_6). The only problem is a few compile warnings (example below). If you
folks think this is preferable then I'll figure a way to suppress the warnings
so they don't clutter the build log.

obj.host/testing/iossim/iossim.gen/iossim/DVTFoundation.h:118:40: warning:
property type 'unsigned long long' is incompatible with type 'NSUInteger' (aka
'unsigned long') inherited from 'NSObject'
@property(readonly) unsigned long long hash;
                                       ^
/Applications/Xcode6-Beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/objc/NSObject.h:18:33:
note: property declared here
@property (readonly) NSUInteger hash;

[justincohen, 2014-06-13 17:13:00]

I think I prefer this one, with a bug saying we should remove the ifdef and old
code when everyone moves to Xcode 6.  lgtm.  rohitrao?

[lliabraa, 2014-06-20 13:21:07]

The CQ bit was checked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-06-20 13:23:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lliabraa@chromium.org/336773002/40001

[commit-bot: I haz the power, 2014-06-20 13:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-20 13:23:25]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[lliabraa, 2014-06-20 14:05:51]

The CQ bit was checked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-06-20 14:07:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lliabraa@chromium.org/336773002/40001

[rohitrao (ping after 24h), 2014-06-20 17:23:32]

Forcing the 10.10 SDK feels worse than defining a new variable, since the
behavior is specifically related to the Xcode version and mac SDK is a weird
proxy for that.

Can you name the variable something like IOSSIM_USE_XCODE_6?

[lliabraa, 2014-06-20 17:26:54]

The CQ bit was unchecked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-06-20 17:29:14]

The CQ bit was unchecked by commit-bot@chromium.org

[lliabraa, 2014-06-20 18:31:37]

+phajdan.jr for OWNERS review on PRESUBMIT.py

[Paweł Hajdan Jr., 2014-06-20 18:46:06]

LGTM

[rohitrao (ping after 24h), 2014-06-20 18:48:08]

LGTM

Thanks!

[lliabraa, 2014-06-20 18:51:05]

The CQ bit was checked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-06-20 19:03:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lliabraa@chromium.org/336773002/80001

[commit-bot: I haz the power, 2014-06-20 19:07:13]

Change committed as 278786