Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: PRESUBMIT.py

Issue 336773002: Get iossim to compile with Xcode 6. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: exclude from presubmit Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | testing/iossim/iossim.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 r'.+_(api|browser|kif|perf|pixel|unit|ui)?test(_[a-z]+)?%s' % 47 r'.+_(api|browser|kif|perf|pixel|unit|ui)?test(_[a-z]+)?%s' %
48 _IMPLEMENTATION_EXTENSIONS, 48 _IMPLEMENTATION_EXTENSIONS,
49 r'.+profile_sync_service_harness%s' % _IMPLEMENTATION_EXTENSIONS, 49 r'.+profile_sync_service_harness%s' % _IMPLEMENTATION_EXTENSIONS,
50 r'.*[/\\](test|tool(s)?)[/\\].*', 50 r'.*[/\\](test|tool(s)?)[/\\].*',
51 # content_shell is used for running layout tests. 51 # content_shell is used for running layout tests.
52 r'content[/\\]shell[/\\].*', 52 r'content[/\\]shell[/\\].*',
53 # At request of folks maintaining this folder. 53 # At request of folks maintaining this folder.
54 r'chrome[/\\]browser[/\\]automation[/\\].*', 54 r'chrome[/\\]browser[/\\]automation[/\\].*',
55 # Non-production example code. 55 # Non-production example code.
56 r'mojo[/\\]examples[/\\].*', 56 r'mojo[/\\]examples[/\\].*',
57 # Launcher for running iOS tests on the simulator.
58 r'testing[/\\]iossim[/\\]iossim\.mm$',
57 ) 59 )
58 60
59 _TEST_ONLY_WARNING = ( 61 _TEST_ONLY_WARNING = (
60 'You might be calling functions intended only for testing from\n' 62 'You might be calling functions intended only for testing from\n'
61 'production code. It is OK to ignore this warning if you know what\n' 63 'production code. It is OK to ignore this warning if you know what\n'
62 'you are doing, as the heuristics used to detect the situation are\n' 64 'you are doing, as the heuristics used to detect the situation are\n'
63 'not perfect. The commit queue will not block on this warning.') 65 'not perfect. The commit queue will not block on this warning.')
64 66
65 67
66 _INCLUDE_ORDER_WARNING = ( 68 _INCLUDE_ORDER_WARNING = (
(...skipping 1536 matching lines...) Expand 10 before | Expand all | Expand 10 after
1603 builders.extend(['cros_x86']) 1605 builders.extend(['cros_x86'])
1604 1606
1605 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1607 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1606 # unless they're .gyp(i) files as changes to those files can break the gyp 1608 # unless they're .gyp(i) files as changes to those files can break the gyp
1607 # step on that bot. 1609 # step on that bot.
1608 if (not all(re.search('^chrome', f) for f in files) or 1610 if (not all(re.search('^chrome', f) for f in files) or
1609 any(re.search('\.gypi?$', f) for f in files)): 1611 any(re.search('\.gypi?$', f) for f in files)):
1610 builders.extend(['android_aosp']) 1612 builders.extend(['android_aosp'])
1611 1613
1612 return GetDefaultTryConfigs(builders) 1614 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | testing/iossim/iossim.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698