Password internals page: notify renderer about logging state on client construction

components/autofill/content/common/autofill_messages.h

Index: components/autofill/content/common/autofill_messages.h
diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h
index f9a99fe670dea7fccaf93328f7517227906990e1..5f6bbb133b45fed7d4bb5607c398799b67af952b 100644
--- a/components/autofill/content/common/autofill_messages.h
+++ b/components/autofill/content/common/autofill_messages.h
@@ -199,6 +199,11 @@ IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsParsed,
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsRendered,
                     std::vector<autofill::PasswordForm> /* forms */)
 
+// A ping to the browser to send AutofillMsg_ChangeLoggingState with the current

[Ilya Sherman, 2014/06/14 00:50:39]

nit: Perhaps we should update the IPC message to be named "SetLoggingState"
rather than "ChangeLoggingState", since the state might not actually change as a
result of calling this method?

[vabr (Chromium), 2014/06/20 10:47:04]

Done.

+// state of the logging activity. This is called when the PasswordAutofillAgent
+// is constructed.
+IPC_MESSAGE_ROUTED0(AutofillHostMsg_UpdateLoggingState);

[engedy, 2014/06/16 09:13:38]

I think this name is somewhat misleading: it suggests that there might be some
side effects involved when this message is received.

Tentatively, how about "NeedLoggingState" or "RequestLoggingState" (or even drop
mention of the use-case from the name, and just say "AgentConstructed").

[vabr (Chromium), 2014/06/20 10:47:04]

Done.

+
 // Notification that this password form was submitted by the user.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormSubmitted,
                     autofill::PasswordForm /* form */)