Password internals page: notify renderer about logging state on client construction

components/autofill/content/common/autofill_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
@@ skipping 181 matching lines @@
 // Notification that password forms have been seen that are candidates for
 // filling/submitting by the password manager.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsParsed,
                     std::vector<autofill::PasswordForm> /* forms */)
 
 // Notification that initial layout has occurred and the following password
 // forms are visible on the page (e.g. not set to display:none.)
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsRendered,
                     std::vector<autofill::PasswordForm> /* forms */)
 
+// A ping to the browser to send AutofillMsg_ChangeLoggingState with the current

[Ilya Sherman, 2014/06/14 00:50:39]

nit: Perhaps we should update the IPC message to be named "SetLoggingState"
rather than "ChangeLoggingState", since the state might not actually change as a
result of calling this method?

[vabr (Chromium), 2014/06/20 10:47:04]

Done.

+// state of the logging activity. This is called when the PasswordAutofillAgent
+// is constructed.
+IPC_MESSAGE_ROUTED0(AutofillHostMsg_UpdateLoggingState);

[engedy, 2014/06/16 09:13:38]

I think this name is somewhat misleading: it suggests that there might be some
side effects involved when this message is received.

Tentatively, how about "NeedLoggingState" or "RequestLoggingState" (or even drop
mention of the use-case from the name, and just say "AgentConstructed").

[vabr (Chromium), 2014/06/20 10:47:04]

Done.

+
 // Notification that this password form was submitted by the user.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormSubmitted,
                     autofill::PasswordForm /* form */)
 
 // Sends |log| to browser for displaying to the user. Only strings passed as an
 // argument to methods overriding SavePasswordProgressLogger::SendLog may become
 // |log|, because those are guaranteed to be sanitized. Never pass a free-form
 // string as |log|.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_RecordSavePasswordProgress,
                     std::string /* log */)
@@ skipping 70 matching lines @@
 IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions,
                     autofill::FormFieldData /* the form field */,
                     gfx::RectF /* input field bounds, window-relative */,
                     std::vector<base::string16> /* suggestions */,
                     std::vector<base::string16> /* realms */)
 
 // Inform browser of data list values for the curent field.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
                     std::vector<base::string16> /* values */,
                     std::vector<base::string16> /* labels */)