Add Net.WebSocket.ResponseCode and ErrorCodes UMA

Add Net.WebSocket.ResponseCode and ErrorCodes UMA

Add histograms to record the response codes seen by all WebSocket
requests, and also the error codes. This will provide more insight into the
reasons for WebSocket connection failures.

BUG=384273
TEST=manually tested with chrome://histograms

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278339

[yhirano, 2014-06-13 10:03:47]

lgtm

[Adam Rice, 2014-06-13 10:07:14]

+asvitkine for OWNERS.

[Adam Rice, 2014-06-13 14:44:55]

yhirano, I discovered it wasn't logging HTTP status codes correctly, please take
another look.

[Adam Rice, 2014-06-17 10:02:04]

On 2014/06/13 14:44:55, Adam Rice wrote:
> yhirano, I discovered it wasn't logging HTTP status codes correctly, please
take
> another look.

ping

[yhirano, 2014-06-17 10:52:44]

Sorry for the late response.
lgtm.

https://codereview.chromium.org/336753002/diff/40001/net/websockets/websocket...
File net/websockets/websocket_stream.cc (right):

https://codereview.chromium.org/336753002/diff/40001/net/websockets/websocket...
net/websockets/websocket_stream.cc:14: #include "net/http/http_util.h"
Do you need this line?

[Alexei Svitkine (slow), 2014-06-17 15:34:27]

https://codereview.chromium.org/336753002/diff/40001/net/websockets/websocket...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/336753002/diff/40001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:562:
UMA_HISTOGRAM_CUSTOM_ENUMERATION(
Use UMA_HISTOGRAM_SPARSE_SLOWLY() here too. It's more efficient than
UMA_HISTOGRAM_CUSTOM_ENUMERATION().

https://codereview.chromium.org/336753002/diff/40001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/336753002/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:15474: +<histogram
name="Net.WebSocket.ResponseCode">
enum="HttpResponseCode"

[Adam Rice, 2014-06-18 01:23:19]

https://codereview.chromium.org/336753002/diff/40001/net/websockets/websocket...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/336753002/diff/40001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:562:
UMA_HISTOGRAM_CUSTOM_ENUMERATION(
On 2014/06/17 15:34:27, Alexei Svitkine wrote:
> Use UMA_HISTOGRAM_SPARSE_SLOWLY() here too. It's more efficient than
> UMA_HISTOGRAM_CUSTOM_ENUMERATION().

Done.

https://codereview.chromium.org/336753002/diff/40001/net/websockets/websocket...
File net/websockets/websocket_stream.cc (right):

https://codereview.chromium.org/336753002/diff/40001/net/websockets/websocket...
net/websockets/websocket_stream.cc:14: #include "net/http/http_util.h"
On 2014/06/17 10:52:44, yhirano wrote:
> Do you need this line?

No. Removed.

https://codereview.chromium.org/336753002/diff/40001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/336753002/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:15474: +<histogram
name="Net.WebSocket.ResponseCode">
On 2014/06/17 15:34:27, Alexei Svitkine wrote:
> enum="HttpResponseCode"

Done.

[Alexei Svitkine (slow), 2014-06-18 16:50:41]

lgtm % comments

https://codereview.chromium.org/336753002/diff/60001/net/websockets/websocket...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/336753002/diff/60001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:564:
"Net.WebSocket.ResponseCode",
Indent 2 more or don't wrap.

https://codereview.chromium.org/336753002/diff/60001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:565:
HttpUtil::MapStatusCodeForHistogram(response_code));
You don't need MapStatusCodeForHistogram, just log the response_code.

https://codereview.chromium.org/336753002/diff/60001/net/websockets/websocket...
File net/websockets/websocket_stream.cc (right):

https://codereview.chromium.org/336753002/diff/60001/net/websockets/websocket...
net/websockets/websocket_stream.cc:193: switch (response_code) {
Nit: Bad indent.

[Adam Rice, 2014-06-19 02:24:07]

https://codereview.chromium.org/336753002/diff/60001/net/websockets/websocket...
File net/websockets/websocket_basic_handshake_stream.cc (right):

https://codereview.chromium.org/336753002/diff/60001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:564:
"Net.WebSocket.ResponseCode",
On 2014/06/18 16:50:41, Alexei Svitkine wrote:
> Indent 2 more or don't wrap.

Done.

https://codereview.chromium.org/336753002/diff/60001/net/websockets/websocket...
net/websockets/websocket_basic_handshake_stream.cc:565:
HttpUtil::MapStatusCodeForHistogram(response_code));
On 2014/06/18 16:50:41, Alexei Svitkine wrote:
> You don't need MapStatusCodeForHistogram, just log the response_code.

Done.

https://codereview.chromium.org/336753002/diff/60001/net/websockets/websocket...
File net/websockets/websocket_stream.cc (right):

https://codereview.chromium.org/336753002/diff/60001/net/websockets/websocket...
net/websockets/websocket_stream.cc:193: switch (response_code) {
On 2014/06/18 16:50:41, Alexei Svitkine wrote:
> Nit: Bad indent.

Done.

[Adam Rice, 2014-06-19 02:28:07]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2014-06-19 02:30:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ricea@chromium.org/336753002/100001

[commit-bot: I haz the power, 2014-06-19 12:05:52]

Change committed as 278339