Add Net.WebSocket.ResponseCode and ErrorCodes UMA

net/websockets/websocket_stream.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/websockets/websocket_stream.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
+#include "base/metrics/sparse_histogram.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_request_headers.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
 #include "net/websockets/websocket_errors.h"
 #include "net/websockets/websocket_event_interface.h"
 #include "net/websockets/websocket_handshake_constants.h"
 #include "net/websockets/websocket_handshake_stream_base.h"
 #include "net/websockets/websocket_handshake_stream_create_helper.h"
@@ skipping 151 matching lines @@
 
   virtual void ContinueSSLRequest() OVERRIDE {
     url_request_->ContinueDespiteLastError();
   }
 
  private:
   URLRequest* url_request_;
 };
 
 void Delegate::OnResponseStarted(URLRequest* request) {
+  // All error codes, including OK and ABORTED, as with
+  // Net.ErrorCodesForMainFrame3
+  UMA_HISTOGRAM_SPARSE_SLOWLY("Net.WebSocket.ErrorCodes",
+                              -request->status().error());
   if (!request->status().is_success()) {
     DVLOG(3) << "OnResponseStarted (request failed)";
     owner_->ReportFailure();
     return;
   }
-  DVLOG(3) << "OnResponseStarted (response code " << request->GetResponseCode()
-           << ")";
-  switch (request->GetResponseCode()) {
+  const int response_code = request->GetResponseCode();
+  DVLOG(3) << "OnResponseStarted (response code " << response_code << ")";
+    switch (response_code) {

[Alexei Svitkine (slow), 2014/06/18 16:50:41]

Nit: Bad indent.

[Adam Rice, 2014/06/19 02:24:07]

Done.

     case HTTP_SWITCHING_PROTOCOLS:
       result_ = CONNECTED;
       owner_->PerformUpgrade();
       return;
 
     case HTTP_UNAUTHORIZED:
     case HTTP_PROXY_AUTHENTICATION_REQUIRED:
       return;
 
     default:
@@ skipping 74 matching lines @@
       new StreamRequestImpl(socket_url,
                             url_request_context,
                             origin,
                             connect_delegate.Pass(),
                             create_helper.Pass()));
   request->Start();
   return request.PassAs<WebSocketStreamRequest>();
 }
 
 }  // namespace net