Issue 336633004: Code cleanup in HistoryService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336633004: Code cleanup in HistoryService (Closed)

Created:
6 years, 6 months ago by sdefresne

Modified:
6 years, 5 months ago

Reviewers:
blundell

CC:
chromium-reviews, browser-components-watch_chromium.org, Nik Shkrob, haaawk1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Code cleanup in HistoryService Remove HistoryService::QueryTopURLsAndRedirects since it is no longer used and is marked for removal. Move definition of QueryMostVisitedURLs and QueryFilteredURLs callbacks after the function comment to follow the pattern used for the other callbacks. BUG=371818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280371

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -75 lines)			Patch
M	chrome/browser/history/history_backend.h	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/history/history_backend.cc	View	1	1 chunk	+0 lines, -29 lines	0 comments	Download
M	chrome/browser/history/history_marshaling.h	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/history/history_service.h	View	1	2 chunks	+6 lines, -26 lines	0 comments	Download
M	chrome/browser/history/history_service.cc	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sdefresne

blundell: Please take a look. nshkrob: FYI as you are mentioned in a TODO

6 years, 6 months ago (2014-06-24 15:16:36 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/336633004/20001

6 years, 5 months ago (2014-06-27 14:56:14 UTC) #5

Message was sent while issue was closed.

Change committed as 280371

Expand Messages | Collapse Messages