Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: chrome/browser/history/history_service.h

Issue 336633004: Code cleanup in HistoryService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_marshaling.h ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index 9d40f25481a598c3877ea2ace82b95b2365ed68e..00a874ab3a175e9d5a0bea0e814e7f79454e0d1d 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -306,35 +306,12 @@ class HistoryService : public CancelableRequestProvider,
CancelableRequestConsumerBase* consumer,
const GetVisibleVisitCountToHostCallback& callback);
- // Called when QueryTopURLsAndRedirects completes. The vector contains a list
- // of the top |result_count| URLs. For each of these URLs, there is an entry
- // in the map containing redirects from the URL. For example, if we have the
- // redirect chain A -> B -> C and A is a top visited URL, then A will be in
- // the vector and "A => {B -> C}" will be in the map.
- typedef base::Callback<
- void(Handle,
- bool, // Did we get the top urls and redirects?
- std::vector<GURL>*, // List of top URLs.
- history::RedirectMap*)> // Redirects for top URLs.
- QueryTopURLsAndRedirectsCallback;
-
- // Request the top |result_count| most visited URLs and the chain of redirects
- // leading to each of these URLs.
- // TODO(Nik): remove this. Use QueryMostVisitedURLs instead.
- Handle QueryTopURLsAndRedirects(
- int result_count,
- CancelableRequestConsumerBase* consumer,
- const QueryTopURLsAndRedirectsCallback& callback);
-
- typedef base::Callback<void(Handle, history::MostVisitedURLList)>
- QueryMostVisitedURLsCallback;
-
- typedef base::Callback<void(Handle, const history::FilteredURLList&)>
- QueryFilteredURLsCallback;
-
// Request the |result_count| most visited URLs and the chain of
// redirects leading to each of these URLs. |days_back| is the
// number of days of history to use. Used by TopSites.
+ typedef base::Callback<void(Handle, history::MostVisitedURLList)>
+ QueryMostVisitedURLsCallback;
+
Handle QueryMostVisitedURLs(int result_count, int days_back,
CancelableRequestConsumerBase* consumer,
const QueryMostVisitedURLsCallback& callback);
@@ -345,6 +322,9 @@ class HistoryService : public CancelableRequestProvider,
// more expensive as additional data points are added in future changes, and
// not useful in most cases. Set |extended_info| to true only if you
// explicitly require the additional data.
+ typedef base::Callback<void(Handle, const history::FilteredURLList&)>
+ QueryFilteredURLsCallback;
+
Handle QueryFilteredURLs(
int result_count,
const history::VisitFilter& filter,
« no previous file with comments | « chrome/browser/history/history_marshaling.h ('k') | chrome/browser/history/history_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698