CustomFrameView Caption Button Inset

Change to CustomFrameView Caption Button Inset.

Restrict increase of button inset to linux only. This will allow the Windows Classic theme to maintain its look, while the updated linux look is still available. This returns the inset size on non-linux platforms to their state pre r272576

BUG=381821
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278173

[jonross, 2014-06-12 15:48:30]

Hey Rob,

This change brings back the non-linux padding for CustomFrameView. With the
linux padding under an if-def

[flackr, 2014-06-13 12:46:33]

https://codereview.chromium.org/336553002/diff/1/ui/views/window/custom_frame...
File ui/views/window/custom_frame_view.cc (right):

https://codereview.chromium.org/336553002/diff/1/ui/views/window/custom_frame...
ui/views/window/custom_frame_view.cc:285: return frame_->IsMaximized() ?
FrameBorderThickness() : kFrameBorderThickness;
This should just return FrameBorderThickness() as that returns exactly what
you're after.

[jonross, 2014-06-13 13:32:16]

https://codereview.chromium.org/336553002/diff/1/ui/views/window/custom_frame...
File ui/views/window/custom_frame_view.cc (right):

https://codereview.chromium.org/336553002/diff/1/ui/views/window/custom_frame...
ui/views/window/custom_frame_view.cc:285: return frame_->IsMaximized() ?
FrameBorderThickness() : kFrameBorderThickness;
On 2014/06/13 12:46:33, flackr wrote:
> This should just return FrameBorderThickness() as that returns exactly what
> you're after.

Done.

[flackr, 2014-06-13 14:03:17]

lgtm

[jonross, 2014-06-13 14:06:03]

Hi Sadrul,

Could you provide an owner review for this change? I am restoring a border
rendering offset for non-linux platforms.

[sadrul, 2014-06-16 15:20:45]

sadrul@ --> sky@

[sky, 2014-06-16 19:44:35]

Your description says task manager, but won't this impact any window that
doesn't explicitly override the position?

[jonross, 2014-06-16 20:39:50]

On 2014/06/16 19:44:35, sky wrote:
> Your description says task manager, but won't this impact any window that
> doesn't explicitly override the position?

Yes this will impact any window that doesn't override this position. I was being
too specific based on the bug description. On builds using ash this is
overridden by CustomFrameViewAsh.

[sky, 2014-06-17 03:02:03]

LGTM - but make sure it's ok with erg too.

[Elliot Glaysher, 2014-06-17 17:24:55]

lgtm

[jonross, 2014-06-17 17:25:29]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2014-06-17 17:27:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jonross@chromium.org/336553002/20001

[commit-bot: I haz the power, 2014-06-17 21:54:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 21:54:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[jonross, 2014-06-17 22:06:57]

One test is failing on the try bots.

I checked this test on master, it is using hard coded points that assume their
targets. However one of the targets is incorrect. When a check is added for the
target the test fails without the changes to CustomFrameView. Updating the
widget size so that the target points are correct exposes the same sizing
failure on master.

I've updated the test in this CL, and disabled it. I plan to file a bug
regarding the incorrect dragging behaviour.

[jonross, 2014-06-18 16:38:01]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2014-06-18 16:38:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jonross@chromium.org/336553002/40001

[commit-bot: I haz the power, 2014-06-18 21:01:47]

Change committed as 278173