CustomFrameView Caption Button Inset

ui/views/window/custom_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/window/custom_frame_view.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/strings/utf_string_conversions.h"
@@ skipping 263 matching lines @@
 
 int CustomFrameView::NonClientTopBorderHeight() const {
   return std::max(FrameBorderThickness() + IconSize(),
                   CaptionButtonY() + kCaptionButtonHeightWithPadding) +
       TitlebarBottomThickness();
 }
 
 int CustomFrameView::CaptionButtonY() const {
   // Maximized buttons start at window top so that even if their images aren't
   // drawn flush with the screen edge, they still obey Fitts' Law.
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
   return frame_->IsMaximized() ? FrameBorderThickness() : kFrameBorderThickness;

[flackr, 2014/06/13 12:46:33]

This should just return FrameBorderThickness() as that returns exactly what
you're after.

[jonross, 2014/06/13 13:32:16]

Done.

+#else
+  return frame_->IsMaximized() ? FrameBorderThickness() : kFrameShadowThickness;
+#endif
 }
 
 int CustomFrameView::TitlebarBottomThickness() const {
   return kTitlebarTopAndBottomEdgeThickness +
       (ShouldShowClientEdge() ? kClientEdgeThickness : 0);
 }
 
 int CustomFrameView::IconSize() const {
 #if defined(OS_WIN)
   // This metric scales up if either the titlebar height or the titlebar font
@@ skipping 318 matching lines @@
     }
     case views::FRAME_BUTTON_CLOSE: {
       button = close_button_;
       break;
     }
   }
   return button;
 }
 
 }  // namespace views