Add AllowNetworkPrediction preference name and enum.

chrome/common/network_prediction_options.h

Index: chrome/common/network_prediction_options.h
diff --git a/chrome/common/network_prediction_options.h b/chrome/common/network_prediction_options.h
new file mode 100644
index 0000000000000000000000000000000000000000..e6a2604a994914be7d2a7d16652d2c5d84ba624e
--- /dev/null
+++ b/chrome/common/network_prediction_options.h
@@ -0,0 +1,20 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_NETWORK_PREDICTION_OPTIONS_H_

[jkarlin, 2014/06/13 11:26:39]

I don't see any other enums for preferences defined in this directory.  Let's
move this to chrome/browser/net/predictor.h so that it becomes
chrome::Predictor::NetworkPredictionOptions.

[Bence, 2014/06/13 13:49:06]

Done.

+#define CHROME_COMMON_NETWORK_PREDICTION_OPTIONS_H_
+
+namespace {

[jkarlin, 2014/06/13 11:26:40]

Should be 'namespace chrome'.  Things in an unnamed namespace can't be seen
outside of the given file.

[Bence, 2014/06/13 13:49:05]

Everything in chrome/browser/net/predictor.h is in the chrome_browser_net
namespace, I moved it into that namespace for consistency.

+
+// The same enum must be used by the platform-dependent UI components.
+// Not used yet, see issue 334602.
+enum class AllowNetworkPredictionOptions = {

[jkarlin, 2014/06/13 11:26:39]

Remove 'class'.  Suggest 'NetworkPredictionOptions' for the name.

[Bence, 2014/06/13 13:49:06]

Done.  Also removed =.

+  ALWAYS,

[jkarlin, 2014/06/13 11:26:39]

NETWORK_PREDICTION_ALWAYS.  Most of our enum values are prefixed with the name
of the enum.

[Bence, 2014/06/13 13:49:05]

Done.

+  WIFI_ONLY,

[jkarlin, 2014/06/13 11:26:39]

NETWORK_PREDICTION_UNMETERED_ONLY

Let's go with UNMETERED as opposed to WIFI.  It's closer to what we actually
want.

[Bence, 2014/06/13 13:49:05]

Are we not worried about the inconsistency between this name and what we are
actually doing (and what is reflected on the UI)?

[jkarlin, 2014/06/13 14:10:40]

Yes, that is a good point.  Okay, let's keep it.

+  NEVER

[jkarlin, 2014/06/13 11:26:40]

NETWORK_PREDICTION_NEVER

[Bence, 2014/06/13 13:49:06]

Done.

+};
+
+}  // namespace

[jkarlin, 2014/06/13 11:26:40]

//  namespace chrome

[Bence, 2014/06/13 13:49:06]

Mute: moved to the namespace that is used by everything else in
chrome/browser/net/predictor.h

+
+#endif  // CHROME_COMMON_NETWORK_PREDICTION_OPTIONS_H_