chrome/common/network_prediction_options.h - Issue 336543003: Add AllowNetworkPrediction preference name and enum.

Side by Side Diff: chrome/common/network_prediction_options.h

Issue 336543003: Add AllowNetworkPrediction preference name and enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_NETWORK_PREDICTION_OPTIONS_H_
	jkarlin 2014/06/13 11:26:39 I don't see any other enums for preferences define I don't see any other enums for preferences defined in this directory. Let's move this to chrome/browser/net/predictor.h so that it becomes chrome::Predictor::NetworkPredictionOptions. Bence 2014/06/13 13:49:06 Done. Show quoted text On 2014/06/13 11:26:39, jkarlin wrote: > I don't see any other enums for preferences defined in this directory. Let's > move this to chrome/browser/net/predictor.h so that it becomes > chrome::Predictor::NetworkPredictionOptions. Done.
	6 #define CHROME_COMMON_NETWORK_PREDICTION_OPTIONS_H_

	7

	8 namespace {
	jkarlin 2014/06/13 11:26:40 Should be 'namespace chrome'. Things in an unname Should be 'namespace chrome'. Things in an unnamed namespace can't be seen outside of the given file. Bence 2014/06/13 13:49:05 Everything in chrome/browser/net/predictor.h is in Show quoted text On 2014/06/13 11:26:40, jkarlin wrote: > Should be 'namespace chrome'. Things in an unnamed namespace can't be seen > outside of the given file. Everything in chrome/browser/net/predictor.h is in the chrome_browser_net namespace, I moved it into that namespace for consistency.
	9

	10 // The same enum must be used by the platform-dependent UI components.

	11 // Not used yet, see issue 334602.

	12 enum class AllowNetworkPredictionOptions = {
	jkarlin 2014/06/13 11:26:39 Remove 'class'. Suggest 'NetworkPredictionOptions Remove 'class'. Suggest 'NetworkPredictionOptions' for the name. Bence 2014/06/13 13:49:06 Done. Also removed =. Show quoted text On 2014/06/13 11:26:39, jkarlin wrote: > Remove 'class'. Suggest 'NetworkPredictionOptions' for the name. Done. Also removed =.
	13 ALWAYS,
	jkarlin 2014/06/13 11:26:39 NETWORK_PREDICTION_ALWAYS. Most of our enum value NETWORK_PREDICTION_ALWAYS. Most of our enum values are prefixed with the name of the enum. Bence 2014/06/13 13:49:05 Done. Show quoted text On 2014/06/13 11:26:39, jkarlin wrote: > NETWORK_PREDICTION_ALWAYS. Most of our enum values are prefixed with the name > of the enum. Done.
	14 WIFI_ONLY,
	jkarlin 2014/06/13 11:26:39 NETWORK_PREDICTION_UNMETERED_ONLY Let's go with U NETWORK_PREDICTION_UNMETERED_ONLY Let's go with UNMETERED as opposed to WIFI. It's closer to what we actually want. Bence 2014/06/13 13:49:05 Are we not worried about the inconsistency between Show quoted text On 2014/06/13 11:26:39, jkarlin wrote: > NETWORK_PREDICTION_UNMETERED_ONLY > > Let's go with UNMETERED as opposed to WIFI. It's closer to what we actually > want. Are we not worried about the inconsistency between this name and what we are actually doing (and what is reflected on the UI)? jkarlin 2014/06/13 14:10:40 Yes, that is a good point. Okay, let's keep it. Show quoted text On 2014/06/13 13:49:05, bnc wrote: > On 2014/06/13 11:26:39, jkarlin wrote: > > NETWORK_PREDICTION_UNMETERED_ONLY > > > > Let's go with UNMETERED as opposed to WIFI. It's closer to what we actually > > want. > > Are we not worried about the inconsistency between this name and what we are > actually doing (and what is reflected on the UI)? Yes, that is a good point. Okay, let's keep it.
	15 NEVER
	jkarlin 2014/06/13 11:26:40 NETWORK_PREDICTION_NEVER NETWORK_PREDICTION_NEVER Bence 2014/06/13 13:49:06 Done. Show quoted text On 2014/06/13 11:26:40, jkarlin wrote: > NETWORK_PREDICTION_NEVER Done.
	16 };

	17

	18 } // namespace
	jkarlin 2014/06/13 11:26:40 // namespace chrome // namespace chrome Bence 2014/06/13 13:49:06 Mute: moved to the namespace that is used by every Show quoted text On 2014/06/13 11:26:40, jkarlin wrote: > // namespace chrome Mute: moved to the namespace that is used by everything else in chrome/browser/net/predictor.h
	19

	20 #endif // CHROME_COMMON_NETWORK_PREDICTION_OPTIONS_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/common/pref_names.h » ('j') | chrome/common/pref_names.h » ('J')