Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 336483002: remove this == null (Closed)

Created:
6 years, 6 months ago by dcarney
Modified:
6 years, 6 months ago
Reviewers:
hans, danno
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -38 lines) Patch
M src/api.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M src/factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M src/hydrogen-load-elimination.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/spaces.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/spaces.cc View 7 chunks +20 lines, -10 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dcarney
ptal
6 years, 6 months ago (2014-06-12 11:18:29 UTC) #1
danno
lgtm
6 years, 6 months ago (2014-06-12 11:57:06 UTC) #2
dcarney
Committed patchset #1 manually as r21807.
6 years, 6 months ago (2014-06-12 12:01:14 UTC) #3
hans
6 years, 6 months ago (2014-06-12 19:33:19 UTC) #4
Message was sent while issue was closed.
Awesome!

Powered by Google App Engine
This is Rietveld 408576698