test/cctest/test-spaces.cc - Issue 336483002: remove this == null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-spaces.cc

Issue 336483002: remove this == null (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-spaces.cc

diff --git a/test/cctest/test-spaces.cc b/test/cctest/test-spaces.cc

index 16ba98f2fba1bc77ab32cc8f1388476357b60f94..ec5d70404d8398bba26cdd681fd6312d345e5db8 100644

--- a/test/cctest/test-spaces.cc

+++ b/test/cctest/test-spaces.cc

@@ -169,7 +169,7 @@ static void VerifyMemoryChunk(Isolate* isolate,

commit_area_size,

executable,

NULL);

- size_t alignment = code_range->exists() ?

+ size_t alignment = code_range != NULL && code_range->valid() ?

MemoryChunk::kAlignment : OS::CommitPageSize();

size_t reserved_size = ((executable == EXECUTABLE))

? RoundUp(header_size + guard_size + reserve_area_size + guard_size,

« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »