Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 336423003: Revert 277797 "Refactor tool-bar event handlers." (Closed)

Created:
6 years, 6 months ago by macourteau
Modified:
6 years, 6 months ago
Reviewers:
Jamie
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 277797 "Refactor tool-bar event handlers." > Refactor tool-bar event handlers. > > The tool-bar is being phased out as part of the apps v2 work, but as > part of the transition, the functionality it provides needs to be shared > between it and the window frame. Step one is to disentangle some of the > event handling code from client_session.js and toolbar.js. > > NOTRY=true > > Review URL: https://codereview.chromium.org/336293003 TBR=jamiewalch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -158 lines) Patch
M trunk/src/remoting/remoting_webapp_files.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/remoting/webapp/client_screen.js View 2 chunks +26 lines, -0 lines 0 comments Download
M trunk/src/remoting/webapp/client_session.js View 14 chunks +34 lines, -33 lines 0 comments Download
M trunk/src/remoting/webapp/event_handlers.js View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/remoting/webapp/options_menu.js View 1 chunk +0 lines, -99 lines 0 comments Download
M trunk/src/remoting/webapp/session_connector.js View 2 chunks +12 lines, -4 lines 0 comments Download
M trunk/src/remoting/webapp/toolbar.js View 3 chunks +3 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
macourteau
6 years, 6 months ago (2014-06-17 19:59:12 UTC) #1
macourteau
6 years, 6 months ago (2014-06-17 19:59:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r277838 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698