Issue 336293003: Refactor tool-bar event handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336293003: Refactor tool-bar event handlers. (Closed)

Created:
6 years, 6 months ago by Jamie

Modified:
6 years, 6 months ago

Reviewers:
garykac

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Refactor tool-bar event handlers. The tool-bar is being phased out as part of the apps v2 work, but as part of the transition, the functionality it provides needs to be shared between it and the window frame. Step one is to disentangle some of the event handling code from client_session.js and toolbar.js. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277797

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+158 lines, -75 lines)			Patch
M	remoting/remoting_webapp_files.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	remoting/webapp/client_screen.js	View	2 chunks	+0 lines, -26 lines	0 comments	Download
M	remoting/webapp/client_session.js	View	14 chunks	+33 lines, -34 lines	0 comments	Download
M	remoting/webapp/event_handlers.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	remoting/webapp/options_menu.js	View	1 chunk	+99 lines, -0 lines	0 comments	Download
M	remoting/webapp/session_connector.js	View	2 chunks	+4 lines, -12 lines	0 comments	Download
M	remoting/webapp/toolbar.js	View	3 chunks	+20 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/336293003/1

6 years, 6 months ago (2014-06-17 17:39:35 UTC) #4

Message was sent while issue was closed.

Change committed as 277797

Expand Messages | Collapse Messages