Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 3364001: X: Map Alt-Up and Alt-Down to Page Up and Page Down. (Closed)

Created:
10 years, 3 months ago by Daniel Erat
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, adlr, anush
Visibility:
Public.

Description

X: Map Alt-Up and Alt-Down to Page Up and Page Down. The XKB changes to do this were pretty straightforward (largely with the help of an old mailing list thread at http://thread.gmane.org/gmane.comp.xfree86.internationalization/1127 and http://thread.gmane.org/gmane.comp.xfree86.internationalization/1177). I quickly ran into an XKB bug that prevents key redirects from working at all. Luckily, a fix for that just got upstreamed about two weeks ago, so I'm pulling it in here. I also ran into a second issue mentioned on the mailing list, where autorepeat is disabled for the keys that I remap. After staring at the XKB code for a long time, I have a tiny deletion that appears to make it work without causing any noticeable ill effects. I'll follow up on the X.org list to find the right way to fix this, but I'd like to check this in in the meantime. BUG=chromium-os:5808 TEST=tried it out

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -1 line) Patch
A x11-base/xorg-server/files/1.7.6-fix-xkb-autorepeat.patch View 1 chunk +21 lines, -0 lines 0 comments Download
A x11-base/xorg-server/files/1.7.6-fix-xkb-redirect-key.patch View 1 chunk +19 lines, -0 lines 0 comments Download
M x11-base/xorg-server/xorg-server-1.7.6.ebuild View 2 chunks +5 lines, -1 line 0 comments Download
A + x11-base/xorg-server/xorg-server-1.7.6-r12.ebuild View 0 chunks +-1 lines, --1 lines 0 comments Download
A x11-misc/xkeyboard-config/files/xkeyboard-config-1.7-nav-keys.patch View 1 chunk +65 lines, -0 lines 0 comments Download
A + x11-misc/xkeyboard-config/xkeyboard-config-1.7-r6.ebuild View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Daniel Erat
10 years, 3 months ago (2010-09-01 22:46:58 UTC) #1
satorux1
LGTM, but Yusuke knows about it more. Please wait for Yusuke to comment. On 2010/09/01 ...
10 years, 3 months ago (2010-09-02 05:31:35 UTC) #2
Yusuke Sato
LGTM. I've confirmed that the change works fine with remapped modifier keys as well (e.g. ...
10 years, 3 months ago (2010-09-02 09:27:20 UTC) #3
davidjames
How about ctrl-up for page-up, ctrl-down for page-down, ctrl-left for home, and ctrl-right for end? ...
10 years, 3 months ago (2010-09-02 15:40:02 UTC) #4
Daniel Erat
10 years, 3 months ago (2010-09-02 15:59:44 UTC) #5
Please take it up with the UI people if you feel strongly about it
(but see also http://crosbug.com/5808, where Kan wrote "NO ctrl, we
are reserving that for apps").

On Thu, Sep 2, 2010 at 8:40 AM,  <davidjames@chromium.org> wrote:
> How about ctrl-up for page-up, ctrl-down for page-down, ctrl-left for home,
> and
> ctrl-right for end? I'd suggest the same with the alt key, but alt-left and
> alt-right are already taken (for back and forward).
>
> The home and end keys are really useful for big pages (e.g. where you'd have
> to
> hit page-down fifty times to get to the bottom of the page)
>
> http://codereview.chromium.org/3364001/show
>

Powered by Google App Engine
This is Rietveld 408576698