Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3021)

Unified Diff: Source/modules/geolocation/Geolocation.idl

Issue 336343002: Use "Dictionary" for PositionOptions instead of Custom binding (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebasing for removing PerWorldBindings (http://crrev.com/330293002) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/geolocation/Geolocation.cpp ('k') | Source/modules/geolocation/PositionOptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/geolocation/Geolocation.idl
diff --git a/Source/modules/geolocation/Geolocation.idl b/Source/modules/geolocation/Geolocation.idl
index ca1b5a5e61d1bdcacbc26360a9bd31eb0a8937a0..2872ed00c5e2710307ea8728a1332edd678b482d 100644
--- a/Source/modules/geolocation/Geolocation.idl
+++ b/Source/modules/geolocation/Geolocation.idl
@@ -29,14 +29,14 @@
NoInterfaceObject,
] interface Geolocation {
// FIXME: should be: PositionOptions options: need PositionOptions.idl and dictionary http:/crbug.com/321462
- [Custom, LogActivity] void getCurrentPosition(PositionCallback successCallback,
+ [LogActivity] void getCurrentPosition(PositionCallback successCallback,
optional PositionErrorCallback errorCallback,
- optional object options);
+ optional Dictionary options);
// FIXME: should be: PositionOptions options: need PositionOptions.idl and dictionary http:/crbug.com/321462
- [Custom, LogActivity] long watchPosition(PositionCallback successCallback,
+ [LogActivity] long watchPosition(PositionCallback successCallback,
optional PositionErrorCallback errorCallback,
- optional object options);
+ optional Dictionary options);
void clearWatch(long watchID);
};
« no previous file with comments | « Source/modules/geolocation/Geolocation.cpp ('k') | Source/modules/geolocation/PositionOptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698