Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2999)

Unified Diff: Source/modules/geolocation/PositionOptions.h

Issue 336343002: Use "Dictionary" for PositionOptions instead of Custom binding (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebasing for removing PerWorldBindings (http://crrev.com/330293002) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/geolocation/Geolocation.idl ('k') | Source/modules/geolocation/PositionOptions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/geolocation/PositionOptions.h
diff --git a/Source/modules/geolocation/PositionOptions.h b/Source/modules/geolocation/PositionOptions.h
index d3d9ffc8a9dfdf7e51e004704e3616ad46f2de82..046e460599c12ea84f17e76196636926eed08051 100644
--- a/Source/modules/geolocation/PositionOptions.h
+++ b/Source/modules/geolocation/PositionOptions.h
@@ -27,13 +27,14 @@
#define PositionOptions_h
#include "platform/heap/Handle.h"
-#include <limits.h>
namespace WebCore {
+class Dictionary;
+
class PositionOptions : public GarbageCollected<PositionOptions> {
public:
- static PositionOptions* create() { return new PositionOptions(); }
+ static PositionOptions* create(const Dictionary&);
void trace(Visitor*) { }
bool enableHighAccuracy() const { return m_highAccuracy; }
@@ -56,14 +57,7 @@ public:
}
private:
- PositionOptions()
- : m_highAccuracy(false)
- , m_maximumAge(0)
- , m_timeout(std::numeric_limits<unsigned>::max())
-
- {
- setMaximumAge(0);
- }
+ explicit PositionOptions(const Dictionary&);
bool m_highAccuracy;
unsigned m_maximumAge;
« no previous file with comments | « Source/modules/geolocation/Geolocation.idl ('k') | Source/modules/geolocation/PositionOptions.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698