Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 336313017: Move libplatform files into v8::platform namespace (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move libplatform files into v8::platform namespace BUG=none R=jkummerow@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M src/libplatform/default-platform.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/libplatform/default-platform.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/libplatform/task-queue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/libplatform/task-queue.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/libplatform/worker-thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/libplatform/worker-thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/test-libplatform.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-libplatform-task-queue.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-libplatform-worker-thread.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-06-30 15:35:32 UTC) #1
Jakob Kummerow
lgtm
6 years, 5 months ago (2014-07-01 07:59:32 UTC) #2
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-01 08:15:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22107 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698