Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 336313007: Mojo: Rename MOJO_WAIT_FLAG_... -> MOJO_HANDLE_SIGNAL_.... (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Rename MOJO_WAIT_FLAG_... -> MOJO_HANDLE_SIGNAL_.... Still to rename: MojoWaitFlagsState and WaitFlagsState (and wait_flags_state.*). Also, remove MOJO_WAIT_FLAG_EVERYTHING. People shouldn't use it (since they'd get unexpected results if we added flags/signals). Tests can still use ~MOJO_HANDLE_SIGNAL_NONE. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278084

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -316 lines) Patch
M mojo/bindings/js/core.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/common/data_pipe_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/handle_watcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/common/handle_watcher_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/common/message_pump_mojo.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/message_pump_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/embedder_unittest.cc View 13 chunks +21 lines, -13 lines 0 comments Download
M mojo/examples/html_viewer/html_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/image_viewer/image_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/wget/wget.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/tests/core_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 8 chunks +13 lines, -12 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest_pure_c.c View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/c/system/types.h View 1 chunk +9 lines, -13 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/sync_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/environment/tests/async_waiter_unittest.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M mojo/public/cpp/system/tests/core_unittest.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
M mojo/public/cpp/test_support/lib/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/utility/run_loop.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/utility/tests/run_loop_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/js/bindings/connector.js View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/js/bindings/core.js View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/spy/spy.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/system/channel_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/core_unittest.cc View 24 chunks +47 lines, -41 lines 0 comments Download
M mojo/system/data_pipe.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/dispatcher_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/system/local_data_pipe.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/system/local_data_pipe_unittest.cc View 24 chunks +33 lines, -33 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M mojo/system/message_pipe_dispatcher_unittest.cc View 13 chunks +15 lines, -15 lines 0 comments Download
M mojo/system/message_pipe_unittest.cc View 7 chunks +17 lines, -12 lines 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M mojo/system/remote_message_pipe_unittest.cc View 11 chunks +12 lines, -11 lines 0 comments Download
M mojo/system/simple_dispatcher_unittest.cc View 28 chunks +56 lines, -53 lines 0 comments Download
M mojo/system/wait_flags_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/waiter_list_unittest.cc View 13 chunks +43 lines, -36 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/345463003/.) Another exciting change!
6 years, 6 months ago (2014-06-18 00:11:05 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-18 03:27:37 UTC) #2
viettrungluu
6 years, 6 months ago (2014-06-18 15:25:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r278084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698