Issue 3362015: Add more special cases to licenses.py for direct source code checkouts....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3362015: Add more special cases to licenses.py for direct source code checkouts.... (Closed)

Created:
10 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Lei Zhang, scr, Evan Martin

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add more special cases to licenses.py for direct source code checkouts. TEST=none BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59154

Patch Set 1 #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	tools/licenses.py	View		1 chunk	+12 lines, -0 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

scr

Hi, I'm trying my first use of the review tool. My first comment is more ...

10 years, 3 months ago (2010-09-10 21:45:29 UTC) #5

Paweł Hajdan Jr.

10 years, 3 months ago (2010-09-10 21:49:30 UTC) #6

http://codereview.chromium.org/3362015/diff/1/2
File tools/licenses.py (right):

http://codereview.chromium.org/3362015/diff/1/2#newcode73
tools/licenses.py:73: "Name": "protobuf",
On 2010/09/10 21:45:29, scr wrote:
> Should this indicate that this is protobuf2 with a string like "protobuf
> (version 2)"?

I don't think so. This licenses.py tool is just yet another bureaucracy, but it
seems we need it.

Expand Messages | Collapse Messages