Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 3362015: Add more special cases to licenses.py for direct source code checkouts.... (Closed)

Created:
7 years, 2 months ago by Paweł Hajdan Jr.
Modified:
6 years, 6 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add more special cases to licenses.py for direct source code checkouts. TEST=none BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59154

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/licenses.py View 1 chunk +12 lines, -0 lines 2 comments Download
Trybot results:

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
7 years, 2 months ago (2010-09-09 20:43:45 UTC) #1
Paweł Hajdan Jr.
ping
7 years, 2 months ago (2010-09-10 21:08:17 UTC) #2
Lei Zhang
LGTM stamp.
7 years, 2 months ago (2010-09-10 21:21:26 UTC) #3
Mark Mentovai
LGTM
7 years, 2 months ago (2010-09-10 21:24:07 UTC) #4
scr
Hi, I'm trying my first use of the review tool. My first comment is more ...
7 years, 2 months ago (2010-09-10 21:45:29 UTC) #5
Paweł Hajdan Jr.
7 years, 2 months ago (2010-09-10 21:49:30 UTC) #6
http://codereview.chromium.org/3362015/diff/1/2
File tools/licenses.py (right):

http://codereview.chromium.org/3362015/diff/1/2#newcode73
tools/licenses.py:73: "Name": "protobuf",
On 2010/09/10 21:45:29, scr wrote:
> Should this indicate that this is protobuf2 with a string like "protobuf
> (version 2)"?

I don't think so. This licenses.py tool is just yet another bureaucracy, but it
seems we need it.

Powered by Google App Engine
This is Rietveld efc10ee0f