Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 3362015: Add more special cases to for direct source code checkouts.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
7 years ago by Paweł Hajdan Jr.
6 years, 4 months ago


Add more special cases to for direct source code checkouts. TEST=none BUG=28291 Committed:

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/ View 1 chunk +12 lines, -0 lines 2 comments Download
Trybot results:
Commit queue not available (can’t edit this change).


Total messages: 6 (0 generated)
Paweł Hajdan Jr.
7 years ago (2010-09-09 20:43:45 UTC) #1
Paweł Hajdan Jr.
7 years ago (2010-09-10 21:08:17 UTC) #2
Lei Zhang
LGTM stamp.
7 years ago (2010-09-10 21:21:26 UTC) #3
Mark Mentovai
7 years ago (2010-09-10 21:24:07 UTC) #4
Hi, I'm trying my first use of the review tool. My first comment is more ...
7 years ago (2010-09-10 21:45:29 UTC) #5
Paweł Hajdan Jr.
7 years ago (2010-09-10 21:49:30 UTC) #6
File tools/ (right):
tools/ "Name": "protobuf",
On 2010/09/10 21:45:29, scr wrote:
> Should this indicate that this is protobuf2 with a string like "protobuf
> (version 2)"?

I don't think so. This tool is just yet another bureaucracy, but it
seems we need it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b