Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 336183003: Add safe numerics classes, imported from Chromium (Closed)

Created:
6 years, 6 months ago by Jakob Kummerow
Modified:
6 years, 6 months ago
CC:
mvstanton, v8-dev
Visibility:
Public.

Description

Add safe numerics classes, imported from Chromium. Not used for anything yet. R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21883

Patch Set 1 : raw, unmodified import #

Patch Set 2 : changes required for V8 #

Total comments: 4

Patch Set 3 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1102 lines, -0 lines) Patch
M BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
A src/base/safe_conversions.h View 1 2 1 chunk +67 lines, -0 lines 0 comments Download
A src/base/safe_conversions_impl.h View 1 2 1 chunk +220 lines, -0 lines 0 comments Download
A src/base/safe_math.h View 1 2 1 chunk +276 lines, -0 lines 0 comments Download
A src/base/safe_math_impl.h View 1 2 1 chunk +531 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jakob Kummerow
Jochen: PTAL. Michael: FYI.
6 years, 6 months ago (2014-06-16 13:08:23 UTC) #1
mvstanton
Thanks, it will be helpful to me!
6 years, 6 months ago (2014-06-16 13:09:39 UTC) #2
Jakob Kummerow
On 2014/06/16 13:08:23, Jakob wrote: > Jochen: PTAL. To clarify: patch set 1 is those ...
6 years, 6 months ago (2014-06-16 13:12:33 UTC) #3
jochen (gone - plz use gerrit)
lgtm with nits https://codereview.chromium.org/336183003/diff/60001/src/base/safe_conversions_impl.h File src/base/safe_conversions_impl.h (right): https://codereview.chromium.org/336183003/diff/60001/src/base/safe_conversions_impl.h#newcode8 src/base/safe_conversions_impl.h:8: #ifndef BASE_SAFE_CONVERSIONS_IMPL_H_ please use V8_BASE_SAFE_CONVERSIONS_IMPL_H_ https://codereview.chromium.org/336183003/diff/60001/src/base/safe_conversions_impl.h#newcode16 ...
6 years, 6 months ago (2014-06-16 14:25:46 UTC) #4
Jakob Kummerow
https://codereview.chromium.org/336183003/diff/60001/src/base/safe_conversions_impl.h File src/base/safe_conversions_impl.h (right): https://codereview.chromium.org/336183003/diff/60001/src/base/safe_conversions_impl.h#newcode8 src/base/safe_conversions_impl.h:8: #ifndef BASE_SAFE_CONVERSIONS_IMPL_H_ On 2014/06/16 14:25:46, jochen traveling until Jun ...
6 years, 6 months ago (2014-06-17 13:53:20 UTC) #5
Jakob Kummerow
6 years, 6 months ago (2014-06-18 11:02:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r21883 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698