Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 336163005: Merge 276752 "Update OS version functions." (Closed)

Created:
6 years, 6 months ago by Robert Sesek
Modified:
6 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, erikwright+watch_chromium.org, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Merge 276752 "Update OS version functions." > Update OS version functions. > > BUG=none > TEST=covered > R=asvitkine@chromium.org, mark@chromium.org > > Review URL: https://codereview.chromium.org/325423005 TBR=avi@chromium.org BUG=380223 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -17 lines) Patch
M base/mac/mac_util.h View 2 chunks +20 lines, -2 lines 0 comments Download
M base/mac/mac_util.mm View 3 chunks +17 lines, -4 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 4 chunks +31 lines, -5 lines 0 comments Download
M base/process/memory_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/test/expectations/expectation.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 2 chunks +10 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Robert Sesek
6 years, 6 months ago (2014-06-19 21:57:16 UTC) #1
Robert Sesek
Committed patchset #1 manually as r278501.
6 years, 6 months ago (2014-06-19 21:57:31 UTC) #2
Avi (use Gerrit)
6 years, 6 months ago (2014-06-19 23:51:44 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698