Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 325423005: Update OS version functions. (Closed)

Created:
6 years, 6 months ago by Avi (use Gerrit)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, asvitkine+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : d'oh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -18 lines) Patch
M base/mac/mac_util.h View 2 chunks +20 lines, -2 lines 0 comments Download
M base/mac/mac_util.mm View 1 3 chunks +17 lines, -4 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 1 4 chunks +31 lines, -5 lines 0 comments Download
M base/process/memory_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/test/expectations/expectation.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 2 chunks +10 lines, -1 line 0 comments Download
M sandbox/mac/os_compatibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
6 years, 6 months ago (2014-06-12 17:54:21 UTC) #1
Alexei Svitkine (slow)
histograms lgtm
6 years, 6 months ago (2014-06-12 17:59:48 UTC) #2
jam
chrome lgtm
6 years, 6 months ago (2014-06-12 18:02:05 UTC) #3
Avi (use Gerrit)
D'oh. https://codereview.chromium.org/325423005/diff/1/base/mac/mac_util.mm File base/mac/mac_util.mm (right): https://codereview.chromium.org/325423005/diff/1/base/mac/mac_util.mm#newcode543 base/mac/mac_util.mm:543: return MacOSXMinorVersion() > MAVERICKS_MINOR_VERSION; On 2014/06/12 18:00:27, Mark ...
6 years, 6 months ago (2014-06-12 18:04:35 UTC) #4
Mark Mentovai
LGTM now.
6 years, 6 months ago (2014-06-12 18:22:56 UTC) #5
Avi (use Gerrit)
6 years, 6 months ago (2014-06-12 18:28:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r276752 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698