Drop traverseNextElement() method from HTMLCollection class

Drop traverseNextElement() method from HTMLCollection class

Drop traverseNextElement() method from HTMLCollection class to avoid code
duplication with traverseForwardToOffset(). This method was only used
by supportedPropertyNames() and updateIdNameCache(). Now these methods
uses the standard traversal API (HTMLCollection::length() / item(index)),
and thus the standard code path for HTMLCollection traversal.

I did not see any regression with this change on Dromaeo:
http://dromaeo.com/?id=223149,223150

R=adamk@chromium.org, esprehn@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176253

[adamk, 2014-06-16 20:25:08]

https://codereview.chromium.org/336133002/diff/1/Source/core/html/HTMLCollect...
File Source/core/html/HTMLCollection.cpp (right):

https://codereview.chromium.org/336133002/diff/1/Source/core/html/HTMLCollect...
Source/core/html/HTMLCollection.cpp:449: unsigned length = this-> length();
Nit: space between "this->" and "length()". Also, curious if this caching is
needed, since CollectionIndexCache already knows how to cache length().

[adamk, 2014-06-16 20:25:08]

https://codereview.chromium.org/336133002/diff/1/Source/core/html/HTMLCollect...
File Source/core/html/HTMLCollection.cpp (right):

https://codereview.chromium.org/336133002/diff/1/Source/core/html/HTMLCollect...
Source/core/html/HTMLCollection.cpp:449: unsigned length = this-> length();
Nit: space between "this->" and "length()". Also, curious if this caching is
needed, since CollectionIndexCache already knows how to cache length().

[Inactive, 2014-06-16 20:41:09]

https://codereview.chromium.org/336133002/diff/1/Source/core/html/HTMLCollect...
File Source/core/html/HTMLCollection.cpp (right):

https://codereview.chromium.org/336133002/diff/1/Source/core/html/HTMLCollect...
Source/core/html/HTMLCollection.cpp:449: unsigned length = this-> length();
On 2014/06/16 20:25:08, adamk wrote:
> Nit: space between "this->" and "length()". Also, curious if this caching is
> needed, since CollectionIndexCache already knows how to cache length().

As I said on my other CL, length() is not a trivial getter as it hides an if
check (to check if the cached node count is valid). Therefore, I think caching
it before the loop is a bit better.

[Inactive, 2014-06-16 20:45:52]

https://codereview.chromium.org/336133002/diff/1/Source/core/html/HTMLCollect...
File Source/core/html/HTMLCollection.cpp (right):

https://codereview.chromium.org/336133002/diff/1/Source/core/html/HTMLCollect...
Source/core/html/HTMLCollection.cpp:449: unsigned length = this-> length();
On 2014/06/16 20:41:09, Chris Dumez wrote:
> On 2014/06/16 20:25:08, adamk wrote:
> > Nit: space between "this->" and "length()". Also, curious if this caching is
> > needed, since CollectionIndexCache already knows how to cache length().
> 
> As I said on my other CL, length() is not a trivial getter as it hides an if
> check (to check if the cached node count is valid). Therefore, I think caching
> it before the loop is a bit better.

I fixed the space issue, thanks. Let me know if you are still want me to stop
caching the length.

[adamk, 2014-06-16 20:59:59]

On 2014/06/16 at 20:41:09, ch.dumez wrote:
>
https://codereview.chromium.org/336133002/diff/1/Source/core/html/HTMLCollect...
> File Source/core/html/HTMLCollection.cpp (right):
> 
>
https://codereview.chromium.org/336133002/diff/1/Source/core/html/HTMLCollect...
> Source/core/html/HTMLCollection.cpp:449: unsigned length = this-> length();
> On 2014/06/16 20:25:08, adamk wrote:
> > Nit: space between "this->" and "length()". Also, curious if this caching is
> > needed, since CollectionIndexCache already knows how to cache length().
> 
> As I said on my other CL, length() is not a trivial getter as it hides an if
check (to check if the cached node count is valid). Therefore, I think caching
it before the loop is a bit better.

I'd say your the major maintainer of this code at this point, so if you like
caching I'm fine with it.

lgtm.

[Inactive, 2014-06-16 21:08:26]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-16 21:09:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/336133002/20001

[commit-bot: I haz the power, 2014-06-16 23:03:16]

Change committed as 176253