Drop traverseNextElement() method from HTMLCollection class

Source/core/html/HTMLCollection.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 347 matching lines @@
 }
 
 Element* HTMLCollection::traverseToLastElement() const
 {
     ASSERT(canTraverseBackward());
     if (shouldOnlyIncludeDirectChildren())
         return lastMatchingChildElement(*this);
     return lastMatchingElement(*this);
 }
 
-inline Element* HTMLCollection::traverseNextElement(Element& previous) const
-{
-    if (overridesItemAfter())
-        return virtualItemAfter(&previous);
-    if (shouldOnlyIncludeDirectChildren())
-        return nextMatchingChildElement(*this, previous);
-    return nextMatchingElement(*this, previous);
-}
-
 Element* HTMLCollection::traverseForwardToOffset(unsigned offset, Element& currentElement, unsigned& currentOffset) const
 {
     ASSERT(currentOffset < offset);
     switch (type()) {
     case HTMLTagCollectionType:
         return traverseMatchingElementsForwardToOffset(toHTMLTagCollection(*this), offset, currentElement, currentOffset);
     case ClassCollectionType:
         return traverseMatchingElementsForwardToOffset(toClassCollection(*this), offset, currentElement, currentOffset);
     default:
         if (overridesItemAfter()) {
@@ skipping 61 matching lines @@
 {
     // As per the specification (http://dom.spec.whatwg.org/#htmlcollection):
     // The supported property names are the values from the list returned by these steps:
     // 1. Let result be an empty list.
     // 2. For each element represented by the collection, in tree order, run these substeps:
     //   1. If element has an ID which is neither the empty string nor is in result, append element's ID to result.
     //   2. If element is in the HTML namespace and has a name attribute whose value is neither the empty string
     //      nor is in result, append element's name attribute value to result.
     // 3. Return result.
     HashSet<AtomicString> existingNames;
-    for (Element* element = traverseToFirstElement(); element; element = traverseNextElement(*element)) {
+    unsigned length = this->length();
+    for (unsigned i = 0; i < length; ++i) {
+        Element* element = item(i);
         const AtomicString& idAttribute = element->getIdAttribute();
         if (!idAttribute.isEmpty()) {
             HashSet<AtomicString>::AddResult addResult = existingNames.add(idAttribute);
             if (addResult.isNewEntry)
                 names.append(idAttribute);
         }
         if (!element->isHTMLElement())
             continue;
         const AtomicString& nameAttribute = element->getNameAttribute();
         if (!nameAttribute.isEmpty() && (type() != DocAll || nameShouldBeVisibleInDocumentAll(toHTMLElement(*element)))) {
             HashSet<AtomicString>::AddResult addResult = existingNames.add(nameAttribute);
             if (addResult.isNewEntry)
                 names.append(nameAttribute);
         }
     }
 }
 
 void HTMLCollection::namedPropertyEnumerator(Vector<String>& names, ExceptionState&)
 {
     supportedPropertyNames(names);
 }
 
 void HTMLCollection::updateIdNameCache() const
 {
     if (hasValidIdNameCache())
         return;
 
     OwnPtrWillBeRawPtr<NamedItemCache> cache = NamedItemCache::create();
-    for (Element* element = traverseToFirstElement(); element; element = traverseNextElement(*element)) {
+    unsigned length = this->length();
+    for (unsigned i = 0; i < length; ++i) {
+        Element* element = item(i);
         const AtomicString& idAttrVal = element->getIdAttribute();
         if (!idAttrVal.isEmpty())
             cache->addElementWithId(idAttrVal, element);
         if (!element->isHTMLElement())
             continue;
         const AtomicString& nameAttrVal = element->getNameAttribute();
         if (!nameAttrVal.isEmpty() && idAttrVal != nameAttrVal && (type() != DocAll || nameShouldBeVisibleInDocumentAll(toHTMLElement(*element))))
             cache->addElementWithName(nameAttrVal, element);
     }
     // Set the named item cache last as traversing the tree may cause cache invalidation.
@@ skipping 24 matching lines @@
 }
 
 void HTMLCollection::trace(Visitor* visitor)
 {
     visitor->trace(m_namedItemCache);
     visitor->trace(m_collectionIndexCache);
     LiveNodeListBase::trace(visitor);
 }
 
 } // namespace WebCore