Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336043002: Perlin noise cleanup. (Closed)

Created:
6 years, 6 months ago by Stephen White
Modified:
6 years, 6 months ago
Reviewers:
sugoi1, sugoi, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Perlin noise cleanup. Remove Simplex noise implementation and now-redundant base classes. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f3b50276a4ad71c9e8ba13d752a5db0c073cae2c

Patch Set 1 #

Total comments: 6

Patch Set 2 : Remove remaining SIMPLEX-related #ifdefs. #

Patch Set 3 : Remove now-redundant fMatrix member. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -394 lines) Patch
M src/effects/SkPerlinNoiseShader.cpp View 1 2 14 chunks +57 lines, -394 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Stephen White
PTAL
6 years, 6 months ago (2014-06-16 12:13:57 UTC) #1
sugoi
https://codereview.chromium.org/336043002/diff/1/src/effects/SkPerlinNoiseShader.cpp File src/effects/SkPerlinNoiseShader.cpp (right): https://codereview.chromium.org/336043002/diff/1/src/effects/SkPerlinNoiseShader.cpp#newcode91 src/effects/SkPerlinNoiseShader.cpp:91: #if SK_SUPPORT_GPU && !defined(SK_USE_SIMPLEX_NOISE) Reference to simplex noise here ...
6 years, 6 months ago (2014-06-16 12:31:26 UTC) #2
Stephen White
https://codereview.chromium.org/336043002/diff/1/src/effects/SkPerlinNoiseShader.cpp File src/effects/SkPerlinNoiseShader.cpp (right): https://codereview.chromium.org/336043002/diff/1/src/effects/SkPerlinNoiseShader.cpp#newcode91 src/effects/SkPerlinNoiseShader.cpp:91: #if SK_SUPPORT_GPU && !defined(SK_USE_SIMPLEX_NOISE) On 2014/06/16 12:31:25, sugoi wrote: ...
6 years, 6 months ago (2014-06-16 14:12:50 UTC) #3
sugoi
lgtm
6 years, 6 months ago (2014-06-16 14:26:29 UTC) #4
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 6 months ago (2014-06-16 17:19:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/336043002/20001
6 years, 6 months ago (2014-06-16 17:19:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 17:19:48 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-16 17:19:49 UTC) #8
reed1
lgtm
6 years, 6 months ago (2014-06-16 17:21:05 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia ...
6 years, 6 months ago (2014-06-16 17:34:19 UTC) #10
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 6 months ago (2014-06-16 17:35:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/336043002/40001
6 years, 6 months ago (2014-06-16 17:35:38 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 17:50:04 UTC) #13
Message was sent while issue was closed. 
Change committed as f3b50276a4ad71c9e8ba13d752a5db0c073cae2c

Powered by Google App Engine
This is Rietveld 408576698