Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 335993002: Convert MIDI permission requests to use WebContents in preparation for switching the code to using … (Closed)

Created:
6 years, 6 months ago by jam
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, creis+watch_chromium.org, benjhayden+dwatch_chromium.org, tfarina, nasko+codewatch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org, miu+watch_chromium.org, site-isolation-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Convert MIDI permission requests to use WebContents in preparation for switching the code to using RenderFrames. As part of this, I also simplified the Content API like I did with geolocation in 277038. BUG=304341 R=avi@chromium.org TBR=mkosiba, nasko Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277293

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -1383 lines) Patch
M android_webview/browser/aw_browser_context.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M android_webview/browser/aw_browser_context.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.h View 1 chunk +7 lines, -0 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +17 lines, -0 lines 0 comments Download
D chrome/browser/media/chrome_midi_permission_context.h View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/media/chrome_midi_permission_context.cc View 1 chunk +0 lines, -305 lines 0 comments Download
D chrome/browser/media/chrome_midi_permission_context_factory.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/media/chrome_midi_permission_context_factory.cc View 1 chunk +0 lines, -45 lines 0 comments Download
A + chrome/browser/media/midi_permission_context.h View 5 chunks +21 lines, -20 lines 0 comments Download
A + chrome/browser/media/midi_permission_context.cc View 10 chunks +40 lines, -36 lines 0 comments Download
A chrome/browser/media/midi_permission_context_factory.h View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/media/midi_permission_context_factory.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/browser/media/midi_permission_infobar_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
A content/browser/media/midi_dispatcher_host.h View 1 chunk +57 lines, -0 lines 0 comments Download
A content/browser/media/midi_dispatcher_host.cc View 1 1 chunk +118 lines, -0 lines 0 comments Download
A + content/browser/media/midi_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/media/midi_host.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/media/midi_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/renderer_host/media/midi_dispatcher_host.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/browser/renderer_host/media/midi_dispatcher_host.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D content/browser/renderer_host/media/midi_host.h View 1 chunk +0 lines, -100 lines 0 comments Download
D content/browser/renderer_host/media/midi_host.cc View 1 chunk +0 lines, -225 lines 0 comments Download
D content/browser/renderer_host/media/midi_host_unittest.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +1 line, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/media/midi_messages.h View 1 chunk +5 lines, -7 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/public/browser/browser_context.h View 1 chunk +0 lines, -19 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +12 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/public/test/test_browser_context.h View 1 chunk +0 lines, -12 lines 0 comments Download
M content/public/test/test_browser_context.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 chunk +0 lines, -12 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
6 years, 6 months ago (2014-06-14 04:05:27 UTC) #1
Avi (use Gerrit)
This LGTM. How many more things are you going to move in this way? I'm ...
6 years, 6 months ago (2014-06-15 01:50:21 UTC) #2
jam
TBR=mkosiba for android_webview, nasko for midi_messages.h On 2014/06/15 01:50:21, Avi wrote: > This LGTM. How ...
6 years, 6 months ago (2014-06-15 03:09:32 UTC) #3
mkosiba (inactive)
android_webview/ LGTM
6 years, 6 months ago (2014-06-16 09:37:36 UTC) #4
nasko
6 years, 6 months ago (2014-06-16 14:17:38 UTC) #5
Message was sent while issue was closed. 
IPC LGTM

Powered by Google App Engine
This is Rietveld 408576698