Source/core/rendering/RenderMedia.cpp - Issue 335963002: Change LayoutState to be stack-allocated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMedia.cpp

Issue 335963002: Change LayoutState to be stack-allocated (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix push function to match old behavior... Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderMedia.cpp

diff --git a/Source/core/rendering/RenderMedia.cpp b/Source/core/rendering/RenderMedia.cpp

index c20652fb055573ba6ce0a8f7b9fab754281bf56f..0062b29205579091659295130f5ae59dd1b9d149 100644

--- a/Source/core/rendering/RenderMedia.cpp

+++ b/Source/core/rendering/RenderMedia.cpp

@@ -62,7 +62,7 @@ void RenderMedia::layout()

if (newSize == oldSize && !controlsNeedLayout)

return;

- LayoutStateMaintainer statePusher(*this, locationOffset());

+ LayoutState state(*this, locationOffset());

controlsRenderer->setLocation(LayoutPoint(borderLeft(), borderTop()) + LayoutSize(paddingLeft(), paddingTop()));

controlsRenderer->style()->setHeight(Length(newSize.height(), Fixed));