Rename "managed (mode|user)" to "supervised user" (part 2)

Rename "managed (mode|user)" to "supervised user" (part 2)

Followup to https://codereview.chromium.org/316863002/

This CL changes:
- c/b/managed_mode/ to c/b/supervised_user/
- "ManagedMode"/"ManagedUser" to "SupervisedUser" in c/b/supervised_user/

Still missing:
- Some stuff outside of c/b/supervised_user/, mostly (but not only) c/b/chromeos/login/managed/
- JavaScript
- Resource names

The remaining things will come in followup CLs.

TBR=nkostylev@chromium.org (c/b/chromeos)
TBR=noms@chromium.org (c/b/profiles)
TBR=thakis@chromium.org (rest of c/)

All the TBRs are just trivial renames.

BUG=385113
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277750

[Marc Treib, 2014-06-16 15:26:40]

PTAL!

Win trybot failure looks unrelated.

[Bernhard Bauer, 2014-06-16 16:06:32]

Could you please file a bug for this, and CC me on major changes like this?

[Marc Treib, 2014-06-16 16:20:32]

On 2014/06/16 16:06:32, Bernhard Bauer wrote:
> Could you please file a bug for this, and CC me on major changes like this?

Sure. Bug number added above.

[Pam (message me for reviews), 2014-06-16 23:51:51]

LGTM, with a few comments below. No need for re-review unless you have
questions.

- Pam

https://codereview.chromium.org/335833003/diff/30001/chrome/browser/supervise...
File chrome/browser/supervised_user/supervised_user_interstitial.h (right):

https://codereview.chromium.org/335833003/diff/30001/chrome/browser/supervise...
chrome/browser/supervised_user/supervised_user_interstitial.h:23: // whitelist
(in "allow only specified sites" mode).
Wow, ghosts of features past.

https://codereview.chromium.org/335833003/diff/30001/chrome/browser/supervise...
File chrome/browser/supervised_user/supervised_user_pref_mapping_service.cc
(right):

https://codereview.chromium.org/335833003/diff/30001/chrome/browser/supervise...
chrome/browser/supervised_user/supervised_user_pref_mapping_service.cc:43:
supervised_users::kChromeAvatarIndex);
Now that this is multiple lines, the style guide mentions that using braces (on
both branches) would be more readable; I agree, although it's not mandatory.

https://codereview.chromium.org/335833003/diff/30001/chrome/browser/supervise...
File chrome/browser/supervised_user/supervised_user_shared_settings_service.h
(right):

https://codereview.chromium.org/335833003/diff/30001/chrome/browser/supervise...
chrome/browser/supervised_user/supervised_user_shared_settings_service.h:32: //
dictionary. The first level is the SU ID, the second level is the key for the
If I'm not mistaken, the entity on the server side is still called the Managed
User ID; it would be nice to add a comment mentioning the mismatch if so.

https://codereview.chromium.org/335833003/diff/30001/chrome/browser/supervise...
File chrome/browser/supervised_user/supervised_user_sync_service.cc (right):

https://codereview.chromium.org/335833003/diff/30001/chrome/browser/supervise...
chrome/browser/supervised_user/supervised_user_sync_service.cc:235: const
std::string& signature_key,
FWIW, the header has these as password_signature_key and
password_encryption_key. They should be changed to match, probably by changing
the header (since they don't use "password_" anywhere else).

[Marc Treib, 2014-06-17 10:04:58]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2014-06-17 10:07:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/treib@chromium.org/335833003/40001

[commit-bot: I haz the power, 2014-06-17 13:43:57]

Change committed as 277750