Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: chrome/browser/chromeos/login/managed/managed_user_password_browsertest.cc

Issue 335833003: Rename "managed (mode|user)" to "supervised user" (part 2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments (+ a few other cleanups) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/threading/sequenced_worker_pool.h" 10 #include "base/threading/sequenced_worker_pool.h"
11 #include "chrome/browser/chrome_notification_types.h" 11 #include "chrome/browser/chrome_notification_types.h"
12 #include "chrome/browser/chromeos/login/login_manager_test.h" 12 #include "chrome/browser/chromeos/login/login_manager_test.h"
13 #include "chrome/browser/chromeos/login/managed/managed_user_test_base.h" 13 #include "chrome/browser/chromeos/login/managed/managed_user_test_base.h"
14 #include "chrome/browser/chromeos/login/managed/supervised_user_authentication.h " 14 #include "chrome/browser/chromeos/login/managed/supervised_user_authentication.h "
15 #include "chrome/browser/chromeos/login/startup_utils.h" 15 #include "chrome/browser/chromeos/login/startup_utils.h"
16 #include "chrome/browser/chromeos/login/ui/login_display_host_impl.h" 16 #include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
17 #include "chrome/browser/chromeos/login/ui/webui_login_view.h" 17 #include "chrome/browser/chromeos/login/ui/webui_login_view.h"
18 #include "chrome/browser/chromeos/login/users/supervised_user_manager.h" 18 #include "chrome/browser/chromeos/login/users/supervised_user_manager.h"
19 #include "chrome/browser/chromeos/net/network_portal_detector_test_impl.h" 19 #include "chrome/browser/chromeos/net/network_portal_detector_test_impl.h"
20 #include "chrome/browser/chromeos/settings/stub_cros_settings_provider.h" 20 #include "chrome/browser/chromeos/settings/stub_cros_settings_provider.h"
21 #include "chrome/browser/managed_mode/managed_user_constants.h" 21 #include "chrome/browser/supervised_user/supervised_user_constants.h"
22 #include "chrome/browser/managed_mode/managed_user_registration_utility.h" 22 #include "chrome/browser/supervised_user/supervised_user_registration_utility.h"
23 #include "chrome/browser/managed_mode/managed_user_registration_utility_stub.h" 23 #include "chrome/browser/supervised_user/supervised_user_registration_utility_st ub.h"
24 #include "chrome/browser/managed_mode/managed_user_shared_settings_service.h" 24 #include "chrome/browser/supervised_user/supervised_user_shared_settings_service .h"
25 #include "chrome/browser/managed_mode/managed_user_shared_settings_service_facto ry.h" 25 #include "chrome/browser/supervised_user/supervised_user_shared_settings_service _factory.h"
26 #include "chrome/browser/managed_mode/managed_user_sync_service.h" 26 #include "chrome/browser/supervised_user/supervised_user_sync_service.h"
27 #include "chrome/browser/managed_mode/managed_user_sync_service_factory.h" 27 #include "chrome/browser/supervised_user/supervised_user_sync_service_factory.h"
28 #include "chromeos/cryptohome/mock_async_method_caller.h" 28 #include "chromeos/cryptohome/mock_async_method_caller.h"
29 #include "chromeos/cryptohome/mock_homedir_methods.h" 29 #include "chromeos/cryptohome/mock_homedir_methods.h"
30 #include "content/public/browser/notification_service.h" 30 #include "content/public/browser/notification_service.h"
31 #include "content/public/test/browser_test_utils.h" 31 #include "content/public/test/browser_test_utils.h"
32 #include "content/public/test/test_utils.h" 32 #include "content/public/test/test_utils.h"
33 #include "sync/api/attachments/attachment_service_proxy_for_test.h" 33 #include "sync/api/attachments/attachment_service_proxy_for_test.h"
34 #include "sync/api/fake_sync_change_processor.h" 34 #include "sync/api/fake_sync_change_processor.h"
35 #include "sync/api/sync_change.h" 35 #include "sync/api/sync_change.h"
36 #include "sync/api/sync_error_factory_mock.h" 36 #include "sync/api/sync_error_factory_mock.h"
37 #include "sync/protocol/sync.pb.h" 37 #include "sync/protocol/sync.pb.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 base::DictionaryValue password; 85 base::DictionaryValue password;
86 password.SetIntegerWithoutPathExpansion( 86 password.SetIntegerWithoutPathExpansion(
87 kSchemaVersion, SupervisedUserAuthentication::SCHEMA_SALT_HASHED); 87 kSchemaVersion, SupervisedUserAuthentication::SCHEMA_SALT_HASHED);
88 password.SetIntegerWithoutPathExpansion(kPasswordRevision, 2); 88 password.SetIntegerWithoutPathExpansion(kPasswordRevision, 2);
89 89
90 password.SetStringWithoutPathExpansion(kPasswordSignature, "signature"); 90 password.SetStringWithoutPathExpansion(kPasswordSignature, "signature");
91 password.SetStringWithoutPathExpansion(kEncryptedPassword, 91 password.SetStringWithoutPathExpansion(kEncryptedPassword,
92 "new-encrypted-password"); 92 "new-encrypted-password");
93 93
94 shared_settings_adapter_->AddChange( 94 shared_settings_adapter_->AddChange(
95 sync_id, managed_users::kChromeOSPasswordData, password, true, false); 95 sync_id, supervised_users::kChromeOSPasswordData, password, true, false);
96 content::RunAllPendingInMessageLoop(); 96 content::RunAllPendingInMessageLoop();
97 } 97 }
98 98
99 // Supervised user signs in for second time, and actual password migration takes 99 // Supervised user signs in for second time, and actual password migration takes
100 // place. 100 // place.
101 IN_PROC_BROWSER_TEST_F(SupervisedUserPasswordTest, 101 IN_PROC_BROWSER_TEST_F(SupervisedUserPasswordTest,
102 DISABLED_PasswordChangeFromUserTest) { 102 DISABLED_PasswordChangeFromUserTest) {
103 EXPECT_CALL(*mock_homedir_methods_, MountEx(_, _, _, _)).Times(1); 103 EXPECT_CALL(*mock_homedir_methods_, MountEx(_, _, _, _)).Times(1);
104 EXPECT_CALL(*mock_homedir_methods_, UpdateKeyEx(_, _, _, _, _)).Times(1); 104 EXPECT_CALL(*mock_homedir_methods_, UpdateKeyEx(_, _, _, _, _)).Times(1);
105 SigninAsSupervisedUser(false, 0, kTestSupervisedUserDisplayName); 105 SigninAsSupervisedUser(false, 0, kTestSupervisedUserDisplayName);
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 147
148 base::DictionaryValue password; 148 base::DictionaryValue password;
149 password.SetIntegerWithoutPathExpansion( 149 password.SetIntegerWithoutPathExpansion(
150 kSchemaVersion, SupervisedUserAuthentication::SCHEMA_SALT_HASHED); 150 kSchemaVersion, SupervisedUserAuthentication::SCHEMA_SALT_HASHED);
151 password.SetIntegerWithoutPathExpansion(kPasswordRevision, 2); 151 password.SetIntegerWithoutPathExpansion(kPasswordRevision, 2);
152 152
153 password.SetStringWithoutPathExpansion(kPasswordSignature, "signature"); 153 password.SetStringWithoutPathExpansion(kPasswordSignature, "signature");
154 password.SetStringWithoutPathExpansion(kEncryptedPassword, 154 password.SetStringWithoutPathExpansion(kEncryptedPassword,
155 "new-encrypted-password"); 155 "new-encrypted-password");
156 shared_settings_adapter_->AddChange( 156 shared_settings_adapter_->AddChange(
157 sync_id, managed_users::kChromeOSPasswordData, password, true, false); 157 sync_id, supervised_users::kChromeOSPasswordData, password, true, false);
158 content::RunAllPendingInMessageLoop(); 158 content::RunAllPendingInMessageLoop();
159 159
160 testing::Mock::VerifyAndClearExpectations(mock_homedir_methods_); 160 testing::Mock::VerifyAndClearExpectations(mock_homedir_methods_);
161 } 161 }
162 162
163 // After that supervised user signs in, and no password change happens. 163 // After that supervised user signs in, and no password change happens.
164 IN_PROC_BROWSER_TEST_F(SupervisedUserPasswordTest, 164 IN_PROC_BROWSER_TEST_F(SupervisedUserPasswordTest,
165 DISABLED_PasswordChangeFromManagerTest) { 165 DISABLED_PasswordChangeFromManagerTest) {
166 EXPECT_CALL(*mock_homedir_methods_, MountEx(_, _, _, _)).Times(1); 166 EXPECT_CALL(*mock_homedir_methods_, MountEx(_, _, _, _)).Times(1);
167 EXPECT_CALL(*mock_homedir_methods_, UpdateKeyEx(_, _, _, _, _)).Times(0); 167 EXPECT_CALL(*mock_homedir_methods_, UpdateKeyEx(_, _, _, _, _)).Times(0);
(...skipping 28 matching lines...) Expand all
196 base::DictionaryValue password; 196 base::DictionaryValue password;
197 password.SetIntegerWithoutPathExpansion( 197 password.SetIntegerWithoutPathExpansion(
198 kSchemaVersion, SupervisedUserAuthentication::SCHEMA_SALT_HASHED); 198 kSchemaVersion, SupervisedUserAuthentication::SCHEMA_SALT_HASHED);
199 password.SetIntegerWithoutPathExpansion(kPasswordRevision, 2); 199 password.SetIntegerWithoutPathExpansion(kPasswordRevision, 2);
200 200
201 password.SetStringWithoutPathExpansion(kPasswordSignature, "signature"); 201 password.SetStringWithoutPathExpansion(kPasswordSignature, "signature");
202 password.SetStringWithoutPathExpansion(kEncryptedPassword, 202 password.SetStringWithoutPathExpansion(kEncryptedPassword,
203 "new-encrypted-password"); 203 "new-encrypted-password");
204 204
205 shared_settings_adapter_->AddChange( 205 shared_settings_adapter_->AddChange(
206 sync_id, managed_users::kChromeOSPasswordData, password, true, false); 206 sync_id, supervised_users::kChromeOSPasswordData, password, true, false);
207 content::RunAllPendingInMessageLoop(); 207 content::RunAllPendingInMessageLoop();
208 } 208 }
209 209
210 // After that manager signs in, and also detects password change. Manager 210 // After that manager signs in, and also detects password change. Manager
211 // performs the migration. 211 // performs the migration.
212 IN_PROC_BROWSER_TEST_F(SupervisedUserPasswordTest, 212 IN_PROC_BROWSER_TEST_F(SupervisedUserPasswordTest,
213 DISABLED_PRE_PasswordChangeUserAndManagerTest) { 213 DISABLED_PRE_PasswordChangeUserAndManagerTest) {
214 const User* managed_user = UserManager::Get()->GetUsers().at(0); 214 const User* managed_user = UserManager::Get()->GetUsers().at(0);
215 215
216 SigninAsManager(1); 216 SigninAsManager(1);
(...skipping 18 matching lines...) Expand all
235 235
236 base::DictionaryValue password; 236 base::DictionaryValue password;
237 password.SetIntegerWithoutPathExpansion( 237 password.SetIntegerWithoutPathExpansion(
238 kSchemaVersion, SupervisedUserAuthentication::SCHEMA_SALT_HASHED); 238 kSchemaVersion, SupervisedUserAuthentication::SCHEMA_SALT_HASHED);
239 password.SetIntegerWithoutPathExpansion(kPasswordRevision, 2); 239 password.SetIntegerWithoutPathExpansion(kPasswordRevision, 2);
240 240
241 password.SetStringWithoutPathExpansion(kPasswordSignature, "signature"); 241 password.SetStringWithoutPathExpansion(kPasswordSignature, "signature");
242 password.SetStringWithoutPathExpansion(kEncryptedPassword, 242 password.SetStringWithoutPathExpansion(kEncryptedPassword,
243 "new-encrypted-password"); 243 "new-encrypted-password");
244 shared_settings_adapter_->AddChange( 244 shared_settings_adapter_->AddChange(
245 sync_id, managed_users::kChromeOSPasswordData, password, true, false); 245 sync_id, supervised_users::kChromeOSPasswordData, password, true, false);
246 content::RunAllPendingInMessageLoop(); 246 content::RunAllPendingInMessageLoop();
247 247
248 testing::Mock::VerifyAndClearExpectations(mock_homedir_methods_); 248 testing::Mock::VerifyAndClearExpectations(mock_homedir_methods_);
249 } 249 }
250 250
251 // When supervised user signs in, password is already migrated, so no migration 251 // When supervised user signs in, password is already migrated, so no migration
252 // should be attempted. 252 // should be attempted.
253 IN_PROC_BROWSER_TEST_F(SupervisedUserPasswordTest, 253 IN_PROC_BROWSER_TEST_F(SupervisedUserPasswordTest,
254 DISABLED_PasswordChangeUserAndManagerTest) { 254 DISABLED_PasswordChangeUserAndManagerTest) {
255 EXPECT_CALL(*mock_homedir_methods_, MountEx(_, _, _, _)).Times(1); 255 EXPECT_CALL(*mock_homedir_methods_, MountEx(_, _, _, _)).Times(1);
256 EXPECT_CALL(*mock_homedir_methods_, UpdateKeyEx(_, _, _, _, _)).Times(0); 256 EXPECT_CALL(*mock_homedir_methods_, UpdateKeyEx(_, _, _, _, _)).Times(0);
257 SigninAsSupervisedUser(false, 1, kTestSupervisedUserDisplayName); 257 SigninAsSupervisedUser(false, 1, kTestSupervisedUserDisplayName);
258 testing::Mock::VerifyAndClearExpectations(mock_homedir_methods_); 258 testing::Mock::VerifyAndClearExpectations(mock_homedir_methods_);
259 } 259 }
260 260
261 } // namespace chromeos 261 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698