Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 335803002: Remove unused text encoding quirks. (Closed)

Created:
6 years, 6 months ago by marja
Modified:
6 years, 6 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Project:
blink
Visibility:
Public.

Description

Remove unused text encoding quirks. 1) Remove more Backslash-as-JPY hacks (some encodings interpret backslash as yen sign). The code was added in https://bugs.webkit.org/show_bug.cgi?id=49714 (r73566). The test used to be editing/selection/find-yensign-and-backslash-with-japanese-fonts-expected.html The feature was removed by https://codereview.chromium.org/27030014 (r159589), but the removal was incomplete. This CL removes the leftover code and test expectation files (the corresponding tests were removed by r159589). 2) Remove isJapaneseEncoding from TextEncodingRegistry.cpp; it was dead code. There used to be bool TextEncoding::isJapanese() (see r16245) which was used by WebCore/loader/Decoder.cpp... but TextEncoding::isJapanese no longer exists, and isJapaneseEncoding appears not to be used any more. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -110 lines) Patch
D LayoutTests/editing/selection/find-yensign-and-backslash-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/editing/selection/find-yensign-and-backslash-with-japanese-fonts-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
M Source/wtf/text/TextEncoding.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/wtf/text/TextEncoding.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/wtf/text/TextEncodingRegistry.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/wtf/text/TextEncodingRegistry.cpp View 4 chunks +0 lines, -56 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
marja
jshin, eseidel, ptal.
6 years, 6 months ago (2014-06-13 09:30:14 UTC) #1
abarth-chromium
That's amazing! LGTM assuming this change is fine with jshin.
6 years, 6 months ago (2014-06-13 17:34:17 UTC) #2
jungshik at Google
On 2014/06/13 17:34:17, abarth wrote: > That's amazing! LGTM assuming this change is fine with ...
6 years, 6 months ago (2014-06-17 17:10:10 UTC) #3
jungshik at Google
On 2014/06/17 17:10:10, Jungshik Shin wrote: > On 2014/06/13 17:34:17, abarth wrote: > > That's ...
6 years, 6 months ago (2014-06-17 17:11:21 UTC) #4
marja
The CQ bit was checked by marja@chromium.org
6 years, 6 months ago (2014-06-18 06:58:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/335803002/1
6 years, 6 months ago (2014-06-18 06:59:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 10:07:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12460)
6 years, 6 months ago (2014-06-18 10:07:25 UTC) #8
marja
6 years, 6 months ago (2014-06-18 13:05:28 UTC) #9
I committed this manually but git cl failed to post an update. Closing.

Powered by Google App Engine
This is Rietveld 408576698