Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 27030014: Remove Backslash-as-JPY hack (Closed)

Created:
7 years, 2 months ago by jungshik at Google
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews, jamesr, dsinclair, eae+blinkwatch, leviw+renderwatch, danakj, dglazkov+blink, Rik, adamk+blink_chromium.org, jchaffraix+rendering, Stephen Chennney, pdr., adamk
Visibility:
Public.

Description

Remove Backslash-as-JPY hack We should not go to extra length to emulate 'the broken' behavior of Windows Japanese fonts on non-Windows platforms. BUG=305827 TEST=Layout test (related tests are removed). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159589

Patch Set 1 #

Patch Set 2 : 3 more layoutests gone #

Patch Set 3 : fix Win bot failure #

Patch Set 4 : TextCodec/Encoding added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1232 lines) Patch
D LayoutTests/editing/selection/find-yensign-and-backslash.html View 1 2 3 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/editing/selection/find-yensign-and-backslash-with-japanese-fonts.html View 1 2 3 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/fast/dom/HTMLOptionElement/option-text.html View 1 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/fast/text/backslash-to-yen-sign.html View 1 2 3 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/text/backslash-to-yen-sign-dynamic.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/text/backslash-to-yen-sign-dynamic-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/text/backslash-to-yen-sign-euc.html View 1 2 3 1 chunk +0 lines, -102 lines 0 comments Download
D LayoutTests/fast/text/backslash-to-yen-sign-euc-expected.txt View 1 chunk +0 lines, -469 lines 0 comments Download
D LayoutTests/fast/text/backslash-to-yen-sign-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.h View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +1 line, -29 lines 0 comments Download
M Source/core/editing/TextIterator.h View 3 chunks +6 lines, -9 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 5 chunks +4 lines, -13 lines 0 comments Download
M Source/core/frame/Frame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/Frame.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/page/Chrome.cpp View 3 chunks +7 lines, -13 lines 0 comments Download
M Source/core/platform/graphics/Font.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/Font.cpp View 6 chunks +0 lines, -6 lines 0 comments Download
D Source/core/platform/text/transcoder/FontTranscoder.h View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/core/platform/text/transcoder/FontTranscoder.cpp View 1 chunk +0 lines, -106 lines 0 comments Download
M Source/core/rendering/HitTestResult.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 1 2 3 chunks +3 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 6 chunks +1 line, -36 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/TextCodecICU.cpp View 1 2 3 1 chunk +3 lines, -18 lines 0 comments Download
M Source/wtf/text/TextEncoding.h View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
Can you take a look? Thanks
7 years, 2 months ago (2013-10-14 10:07:51 UTC) #1
eseidel
lgtm Wow.
7 years, 2 months ago (2013-10-14 14:58:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/27030014/11001
7 years, 2 months ago (2013-10-14 14:58:51 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-14 16:03:02 UTC) #4
Message was sent while issue was closed. 
Change committed as 159589

Powered by Google App Engine
This is Rietveld 408576698