Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 335783003: Move navigatorcontentutils directory to top of LayoutTests (Closed)

Created:
6 years, 6 months ago by gyuyoung-inactive
Modified:
6 years, 6 months ago
Reviewers:
haraken, ojan
CC:
blink-reviews, gyuyoung.kim_webkit.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move navigatorcontentutils directory to top of LayoutTests Modules tests have been placed in top of LayoutTests. So, this cl moves navigatorcontentutils to top of LayoutTests. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176105

Patch Set 1 #

Patch Set 2 : Fix wrong include path in tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -435 lines) Patch
D LayoutTests/fast/dom/navigatorcontentutils/is-protocol-handler-registered.html View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/fast/dom/navigatorcontentutils/is-protocol-handler-registered-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/dom/navigatorcontentutils/register-protocol-handler.html View 1 chunk +0 lines, -119 lines 0 comments Download
D LayoutTests/fast/dom/navigatorcontentutils/register-protocol-handler-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler.html View 1 chunk +0 lines, -126 lines 0 comments Download
D LayoutTests/fast/dom/navigatorcontentutils/unregister-protocol-handler-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download
A + LayoutTests/navigatorcontentutils/is-protocol-handler-registered.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/navigatorcontentutils/is-protocol-handler-registered-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/navigatorcontentutils/register-protocol-handler.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/navigatorcontentutils/register-protocol-handler-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/navigatorcontentutils/unregister-protocol-handler.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/navigatorcontentutils/unregister-protocol-handler-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
gyuyoung-inactive
Add haraken.
6 years, 6 months ago (2014-06-13 03:52:04 UTC) #1
haraken
LGTM, but I'd like to have ojan@ confirm.
6 years, 6 months ago (2014-06-13 04:05:01 UTC) #2
ojan
On 2014/06/13 04:05:01, haraken wrote: > LGTM, but I'd like to have ojan@ confirm. I'm ...
6 years, 6 months ago (2014-06-13 04:20:41 UTC) #3
gyuyoung-inactive
On 2014/06/13 04:20:41, ojan wrote: > On 2014/06/13 04:05:01, haraken wrote: > > LGTM, but ...
6 years, 6 months ago (2014-06-13 04:38:47 UTC) #4
ojan
I don't feel strongly about this. Go ahead and commit.
6 years, 6 months ago (2014-06-13 04:54:55 UTC) #5
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 6 months ago (2014-06-13 05:00:39 UTC) #6
gyuyoung-inactive
On 2014/06/13 04:54:55, ojan wrote: > I don't feel strongly about this. Go ahead and ...
6 years, 6 months ago (2014-06-13 05:00:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/335783003/1
6 years, 6 months ago (2014-06-13 05:01:06 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-13 06:07:30 UTC) #9
gyuyoung-inactive
The CQ bit was unchecked by gyuyoung.kim@samsung.com
6 years, 6 months ago (2014-06-13 06:56:47 UTC) #10
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 6 months ago (2014-06-13 07:41:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/335783003/20001
6 years, 6 months ago (2014-06-13 07:41:53 UTC) #12
gyuyoung-inactive
On 2014/06/13 06:56:47, gyuyoung wrote: > The CQ bit was unchecked by mailto:gyuyoung.kim@samsung.com I missed ...
6 years, 6 months ago (2014-06-13 07:42:10 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-13 08:43:52 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 09:44:28 UTC) #15
Message was sent while issue was closed.
Change committed as 176105

Powered by Google App Engine
This is Rietveld 408576698