Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: Source/core/fetch/ResourceFetcher.h

Issue 335633002: Oilpan: Fix leaks through RenderStyle objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/css/CSSFontSelector.h ('K') | « Source/core/css/CSSFontSelector.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fetch/ResourceFetcher.h
diff --git a/Source/core/fetch/ResourceFetcher.h b/Source/core/fetch/ResourceFetcher.h
index 317ad9561009ea421ae874e502d18a7582b24cc7..657b5f6e6c978b8a9335b335ea426f6f23668f3b 100644
--- a/Source/core/fetch/ResourceFetcher.h
+++ b/Source/core/fetch/ResourceFetcher.h
@@ -205,7 +205,10 @@ private:
HashSet<String> m_validatedURLs;
mutable DocumentResourceMap m_documentResources;
- RawPtrWillBeMember<Document> m_document;
+ // FIXME: Oilpan: Ideally this should just be a trace Member but that will
haraken 2014/06/12 14:09:38 a traced Member
Mads Ager (chromium) 2014/06/12 14:13:01 Done.
+ // currently leak because RenderStyle and its data is not on the heap.
haraken 2014/06/12 14:09:38 are not
Mads Ager (chromium) 2014/06/12 14:13:02 Done.
+ // See crbug.com/383860 for details.
+ RawPtrWillBeWeakMember<Document> m_document;
DocumentLoader* m_documentLoader;
int m_requestCount;
« Source/core/css/CSSFontSelector.h ('K') | « Source/core/css/CSSFontSelector.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698