Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: Source/core/css/CSSFontSelector.h

Issue 335633002: Oilpan: Fix leaks through RenderStyle objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/fetch/ResourceFetcher.h » ('j') | Source/core/fetch/ResourceFetcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSFontSelector.h
diff --git a/Source/core/css/CSSFontSelector.h b/Source/core/css/CSSFontSelector.h
index 2ae019dd6241f8ed01ed53a0be80322b6ab5698a..a40fad60d50a42e33f2b470d72b01dd5f4087ac2 100644
--- a/Source/core/css/CSSFontSelector.h
+++ b/Source/core/css/CSSFontSelector.h
@@ -86,7 +86,10 @@ private:
void dispatchInvalidationCallbacks();
- RawPtrWillBeMember<Document> m_document;
+ // FIXME: Oilpan: Ideally this should just be a trace Member but that will
haraken 2014/06/12 14:09:38 a trace Member => a traced Member
Mads Ager (chromium) 2014/06/12 14:13:01 Done.
+ // currently leak because RenderStyle and its data is not on the heap.
haraken 2014/06/12 14:09:38 is not => are not
Mads Ager (chromium) 2014/06/12 14:13:01 Done.
+ // See crbug.com/383860 for details.
+ RawPtrWillBeWeakMember<Document> m_document;
// FIXME: Move to Document or StyleEngine.
FontFaceCache m_fontFaceCache;
WillBeHeapHashSet<RawPtrWillBeWeakMember<CSSFontSelectorClient> > m_clients;
« no previous file with comments | « no previous file | Source/core/fetch/ResourceFetcher.h » ('j') | Source/core/fetch/ResourceFetcher.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698