Chromium Code Reviews Chromium Code Reviews
Issue 335633002:
Oilpan: Fix leaks through RenderStyle objects. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2007, 2008, 2011 Apple Inc. All rights reserved. | 2 * Copyright (C) 2007, 2008, 2011 Apple Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions | 5 * modification, are permitted provided that the following conditions |
| 6 * are met: | 6 * are met: |
| 7 * 1. Redistributions of source code must retain the above copyright | 7 * 1. Redistributions of source code must retain the above copyright |
| 8 * notice, this list of conditions and the following disclaimer. | 8 * notice, this list of conditions and the following disclaimer. |
| 9 * 2. Redistributions in binary form must reproduce the above copyright | 9 * 2. Redistributions in binary form must reproduce the above copyright |
| 10 * notice, this list of conditions and the following disclaimer in the | 10 * notice, this list of conditions and the following disclaimer in the |
| (...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 79 const GenericFontFamilySettings& genericFontFamilySettings() const { return m_genericFontFamilySettings; } | 79 const GenericFontFamilySettings& genericFontFamilySettings() const { return m_genericFontFamilySettings; } |
| 80 void updateGenericFontFamilySettings(Document&); | 80 void updateGenericFontFamilySettings(Document&); |
| 81 | 81 |
| 82 virtual void trace(Visitor*); | 82 virtual void trace(Visitor*); |
| 83 | 83 |
| 84 private: | 84 private: |
| 85 explicit CSSFontSelector(Document*); | 85 explicit CSSFontSelector(Document*); |
| 86 | 86 |
| 87 void dispatchInvalidationCallbacks(); | 87 void dispatchInvalidationCallbacks(); |
| 88 | 88 |
| 89 RawPtrWillBeMember<Document> m_document; | 89 // FIXME: Oilpan: Ideally this should just be a trace Member but that will |
|
haraken
2014/06/12 14:09:38
a trace Member => a traced Member
Mads Ager (chromium)
2014/06/12 14:13:01
Done.
| |
| 90 // currently leak because RenderStyle and its data is not on the heap. | |
|
haraken
2014/06/12 14:09:38
is not => are not
Mads Ager (chromium)
2014/06/12 14:13:01
Done.
| |
| 91 // See crbug.com/383860 for details. | |
| 92 RawPtrWillBeWeakMember<Document> m_document; | |
| 90 // FIXME: Move to Document or StyleEngine. | 93 // FIXME: Move to Document or StyleEngine. |
| 91 FontFaceCache m_fontFaceCache; | 94 FontFaceCache m_fontFaceCache; |
| 92 WillBeHeapHashSet<RawPtrWillBeWeakMember<CSSFontSelectorClient> > m_clients; | 95 WillBeHeapHashSet<RawPtrWillBeWeakMember<CSSFontSelectorClient> > m_clients; |
| 93 | 96 |
| 94 RefPtrWillBeMember<FontLoader> m_fontLoader; | 97 RefPtrWillBeMember<FontLoader> m_fontLoader; |
| 95 GenericFontFamilySettings m_genericFontFamilySettings; | 98 GenericFontFamilySettings m_genericFontFamilySettings; |
| 96 }; | 99 }; |
| 97 | 100 |
| 98 } // namespace WebCore | 101 } // namespace WebCore |
| 99 | 102 |
| 100 #endif // CSSFontSelector_h | 103 #endif // CSSFontSelector_h |
| OLD | NEW |
