Fix SkPaint::measureText for stroked hairline text

Fix SkPaint::measureText for stroked hairline text

SkPaint::measureText and text drawing used different criteria for
determining whether text should be drawn as paths or not.

Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
positioning in the rendering. Mainly added in order to define what is the
expected text rendering when hairline stroke is used with various transform
options.

The testcase also tries to note or highlight the fact that SkPaint::measureText
is not expected to produce intuitively matching results when compared to a
rendering, if the rendering is done so that the device ends up having a device
transform.

This fixes the glyph_pos_h_s (hairline, stroked) test-case.

Ignore shadertext2_pdf-poppler.png gm on
Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.

Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793

[jvanverth1, 2014-06-12 14:36:23]

This looks reasonable, but adding reed@ to be sure (and to get permission to
change public interface).

[reed1, 2014-06-12 15:12:04]

api lgtm

[Kimmo Kinnunen, 2014-06-16 05:18:26]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-06-16 05:18:45]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/335603003/40001

[commit-bot: I haz the power, 2014-06-16 05:33:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Win7-VS2010-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Debug-Trybot/build...)
  Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...)

[commit-bot: I haz the power, 2014-06-16 05:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 05:39:35]

Try jobs failed on following builders:
  Build-Win7-VS2010-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Debug-Trybot/build...)

[Kimmo Kinnunen, 2014-06-16 05:58:41]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-06-16 05:59:45]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/335603003/60001

[commit-bot: I haz the power, 2014-06-16 06:13:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...)

[commit-bot: I haz the power, 2014-06-16 06:28:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 06:28:15]

Try jobs failed on following builders:
  Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...)

[Kimmo Kinnunen, 2014-06-17 07:08:53]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-06-17 07:09:13]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/335603003/60001

[commit-bot: I haz the power, 2014-06-17 07:38:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 07:38:14]

Try jobs failed on following builders:
  Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...)

[Kimmo Kinnunen, 2014-06-19 07:36:19]

Jim,
Is it ok to add  shadertext2_pdf-poppler.png to ignore on ubuntu 13.10 debug
build? I cannot repro it on my 12.04. I could maybe inspect the result once the
patch has landed?

The error is following: 
[*] 1 ExpectationsMismatch: shadertext2_pdf-poppler.png 

http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...

[Jvsquare, 2014-06-19 13:39:27]

On 2014/06/19 07:36:19, kkinnunen wrote:
> Jim,
> Is it ok to add  shadertext2_pdf-poppler.png to ignore on ubuntu 13.10 debug
> build? I cannot repro it on my 12.04. I could maybe inspect the result once
the
> patch has landed?
> 
> The error is following: 
> [*] 1 ExpectationsMismatch: shadertext2_pdf-poppler.png 
> 
>
http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...

That sounds fine -- you should be able to see the difference on the rebaseline
server once the patch lands.

[Kimmo Kinnunen, 2014-06-23 05:02:56]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-06-23 05:03:39]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/335603003/80001

[commit-bot: I haz the power, 2014-06-23 05:18:19]

Change committed as 196af738027c5e18c3eb792dbcaf90ef27821793

[rmistry, 2014-06-23 11:53:02]

This CL appears to have caused many shader text GM failures across multiple
builders. Is this expected?

Example failures:

http://108.170.220.120:10117/builders/Test-ChromeOS-Daisy-MaliT604-Arm7-Relea...
http://108.170.220.120:10117/builders/Test-Win8-ShuttleA-HD7770-x86-Debug/bui...

[rmistry, 2014-06-23 12:38:55]

A revert of this CL has been created in
https://codereview.chromium.org/354433002/ by rmistry@google.com.

The reason for reverting is: Caused many shadertext GM failures.

[rmistry, 2014-06-23 12:40:53]

On 2014/06/23 12:38:55, rmistry wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/354433002/ by mailto:rmistry@google.com.
> 
> The reason for reverting is: Caused many shadertext GM failures.

These are the builders that failed the CompareGM step due to this CL (which has
been reverted):

Test-Win8-ShuttleA-GTX660-x86-Debug: CompareGMs
Test-Win8-ShuttleA-GTX660-x86-Release: CompareGMs
Test-Win8-ShuttleA-GTX660-x86_64-Release: CompareGMs
Test-Win8-ShuttleA-HD7770-x86-Debug: CompareGMs
Test-Win8-ShuttleA-HD7770-x86-Release: CompareGMs
Test-Win8-ShuttleA-HD7770-x86_64-Release: CompareGMs
Test-Win7-ShuttleA-HD2000-x86-Debug: CompareGMs
Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE: CompareGMs
Test-Win7-ShuttleA-HD2000-x86-Release: CompareGMs
Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE: CompareGMs
Test-Win7-ShuttleA-HD2000-x86_64-Release: CompareGMs
Test-ChromeOS-Alex-GMA3150-x86-Debug: CompareGMs
Test-ChromeOS-Alex-GMA3150-x86-Release: CompareGMs
Test-ChromeOS-Daisy-MaliT604-Arm7-Debug: CompareGMs
Test-ChromeOS-Daisy-MaliT604-Arm7-Release: CompareGMs
Test-ChromeOS-Link-HD4000-x86_64-Debug: CompareGMs
Test-ChromeOS-Link-HD4000-x86_64-Release: CompareGMs
Test-Ubuntu12-ShuttleA-GTX660-x86-Debug: CompareGMs
Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug: CompareGMs
Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release: CompareGMs

[Kimmo Kinnunen, 2014-06-23 13:07:54]

On 2014/06/23 12:40:53, rmistry wrote:
> On 2014/06/23 12:38:55, rmistry wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/354433002/ by mailto:rmistry@google.com.
> > 
> > The reason for reverting is: Caused many shadertext GM failures.
> 
> These are the builders that failed the CompareGM step due to this CL (which
has
> been reverted):
> 

Right.. A rebaseline was up for review in this issue:
https://codereview.chromium.org/347393002/

I can not commit rebaselines directly..

[rmistry, 2014-06-23 13:09:31]

On 2014/06/23 13:07:54, kkinnunen wrote:
> On 2014/06/23 12:40:53, rmistry wrote:
> > On 2014/06/23 12:38:55, rmistry wrote:
> > > A revert of this CL has been created in
> > > https://codereview.chromium.org/354433002/ by mailto:rmistry@google.com.
> > > 
> > > The reason for reverting is: Caused many shadertext GM failures.
> > 
> > These are the builders that failed the CompareGM step due to this CL (which
> has
> > been reverted):
> > 
> 
> Right.. A rebaseline was up for review in this issue:
> https://codereview.chromium.org/347393002/
> 
> I can not commit rebaselines directly..

Let me know when the rebaseline CL is ready to be submitted, I will then revert
this revert.

[rmistry, 2014-06-23 13:57:51]

On 2014/06/23 13:09:31, rmistry wrote:
> On 2014/06/23 13:07:54, kkinnunen wrote:
> > On 2014/06/23 12:40:53, rmistry wrote:
> > > On 2014/06/23 12:38:55, rmistry wrote:
> > > > A revert of this CL has been created in
> > > > https://codereview.chromium.org/354433002/ by mailto:rmistry@google.com.
> > > > 
> > > > The reason for reverting is: Caused many shadertext GM failures.
> > > 
> > > These are the builders that failed the CompareGM step due to this CL
(which
> > has
> > > been reverted):
> > > 
> > 
> > Right.. A rebaseline was up for review in this issue:
> > https://codereview.chromium.org/347393002/
> > 
> > I can not commit rebaselines directly..
> 
> Let me know when the rebaseline CL is ready to be submitted, I will then
revert
> this revert.

Looks like the rebaseline CL is ready to be submitted. I will revert my revert.