Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 335583003: Remove unnecessary .get() in DOMEditor::ReplaceChildNodeAction. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove unnecessary .get() in DOMEditor::ReplaceChildNodeAction. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M Source/core/inspector/DOMEditor.cpp View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tkent
Please review this trivial patch.
6 years, 6 months ago (2014-06-12 10:13:32 UTC) #1
pfeldman
lgtm
6 years, 6 months ago (2014-06-12 10:20:51 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-12 10:22:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/335583003/1
6 years, 6 months ago (2014-06-12 10:23:40 UTC) #4
haraken
LGTM
6 years, 6 months ago (2014-06-12 10:27:36 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-12 10:50:31 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 11:37:58 UTC) #7
Message was sent while issue was closed.
Change committed as 176020

Powered by Google App Engine
This is Rietveld 408576698